My two cents on the last two changes: * File names with spaces are so toxic (at least to those of us who use Stone Age tools such as ‘sed’) that I’d be tempted to do a force-push; * I don’t add a release announcement until after the vote has passed.
But then I’m pedantic about maintaining a clean commit history that (on occasion) covers up my past mistakes. Julian > On Sep 5, 2018, at 3:56 PM, francischu...@apache.org wrote: > > Update hash in release announcement > > > Project: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/repo > Commit: > http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/7348c3bf > Tree: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/tree/7348c3bf > Diff: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/diff/7348c3bf > > Branch: refs/heads/master > Commit: 7348c3bf1d76b32fd795857259c18718860d61c8 > Parents: 0e1ae23 > Author: Francis Chuang <francischu...@apache.org> > Authored: Thu Sep 6 08:56:06 2018 +1000 > Committer: Francis Chuang <francischu...@apache.org> > Committed: Thu Sep 6 08:56:06 2018 +1000 > > ---------------------------------------------------------------------- > site/_posts/2018-09-10-release-avatica-go-3.1.0.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/blob/7348c3bf/site/_posts/2018-09-10-release-avatica-go-3.1.0.md > ---------------------------------------------------------------------- > diff --git a/site/_posts/2018-09-10-release-avatica-go-3.1.0.md > b/site/_posts/2018-09-10-release-avatica-go-3.1.0.md > index 45fd7bd..e232f79 100644 > --- a/site/_posts/2018-09-10-release-avatica-go-3.1.0.md > +++ b/site/_posts/2018-09-10-release-avatica-go-3.1.0.md > @@ -5,7 +5,7 @@ author: francischuang > version: 3.1.0 > categories: [release] > tag: v3-1-0 > -sha: d328101 > +sha: 0e1ae23 > component: avatica-go > --- > <!-- >
