+1 (binding) * Checked signatures and checksums and README * Build and tests pass * Nothing major reported on https://goreportcard.com/report/github.com/apache/calcite-avatica-go * License and Notice looks good
One minor documentation issue: README and https://calcite.apache.org/avatica/docs/go_client_reference.html differ in terms of dep vs go get modules. Might get fixed on website push with 3.1.0 release? Kevin Risden On Sat, Sep 8, 2018 at 2:33 AM Julian Hyde <jh...@apache.org> wrote: > +1 (binding) > > Checked checksums/signatures, L&N, README, file headers. > > Checked that contents of .tar.gz are consistent with git commit. > > The issues noted last time (copyright date and .idea directory) are > resolved. Thanks, Francis! > > Julian > > On Fri, Sep 7, 2018 at 5:35 PM Josh Elser <els...@apache.org> wrote: > > > > +1 (binding) > > > > * xsums/sigs OK > > * Can "build" from source > > * Ran tests successfully > > * L&N look OK > > * Checked packages in Gopkg.toml are permissively licensed > > * Spot-checked files for license headers (this would be nice to automate > > in a script) > > > > On 9/5/18 4:05 PM, Francis Chuang wrote: > > > Hi all, > > > > > > I have created a release for Apache Calcite Avatica Go 3.1.0, release > > > candidate 2. > > > > > > The release notes are available here: > > > > https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md > > > > > > > > > The commit to be voted on: > > > > http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/0e1ae23d79c9f6d92337a13c9c15318a1c7570dc > > > > > > > > > The hash is 0e1ae23d79c9f6d92337a13c9c15318a1c7570dc > > > > > > The artifacts to be voted on are located here: > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc2/ > > > > > > > > > The hashes of the artifacts are as follows: > > > > > > src.tar.gz 0B396E74 3FD68D9D DD311A81 B0441401 DDB7E414 955A4D78 > > > 761747E3 D68C8DEA > > > > > > Release artifacts are signed with the following key: > > > https://people.apache.org/keys/committer/francischuang.asc > > > > > > Instructions for running the test suite is located here: > > > > https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing > > > > > > > > > Please vote on releasing this package as Apache Calcite Avatica Go > 3.1.0. > > > > > > To run the tests without a Go environment, install docker and > > > docker-compose. Then, in the root of the release's directory, run: > > > docker-compose up --build > > > > > > The vote is open for the next 72 hours and passes if a majority of > > > at least three +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Calcite Avatica Go 3.1.0 > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > [ ] -1 Do not release this package because... > > > > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > Francis > > > > > > >
