I think a detail that was dropped here is that this only affects a
`deploy`, not a normal dev build.
Re-reading the context on CALCITE-2385 reminded me about what exactly
Francis was trying to do. This shouldn't being affecting the average
person, just those deploying SNAPSHOTs by hand. There may be some
trickery done in Maven to work around this, but I don't have the time to
look into that presently.
On 11/19/18 12:27 PM, Kevin Risden wrote:
So is it possible to change the logic so this only gets triggered during a
release? Seems weird to have to specify -DskipDockerCheck on a regular
build. My local jenkins has been failing too and I'm hesitant to make the
same change. I would guess builds from the command line will fail too?
Kevin Risden
On Mon, Nov 19, 2018 at 12:07 PM Michael Mior <mm...@apache.org> wrote:
No problem. I also gave you access so you should be able to do this
yourself in the future. Let me know if that doesn't seem to have worked.
--
Michael Mior
mm...@apache.org
Le dim. 18 nov. 2018 à 21:10, Francis Chuang <francischu...@apache.org> a
écrit :
Thanks, Michael!
On 19/11/2018 11:37 am, Michael Mior wrote:
Thanks Francis! I updated the configuration on Jenkins and triggered a
rebuild and looks like things pass now.
--
Michael Mior
mm...@apache.org
Le dim. 18 nov. 2018 à 17:20, Francis Chuang <francischu...@apache.org
a
écrit :
This is the latest test failure for Avatica on Jenkins:
https://builds.apache.org/job/Calcite-Avatica-Master/129/jdk=JDK%201.8%20(latest),label_exp=ubuntu&&!cloud-slave/console
It looks like the failure is due to
check-dockerhub-dockerfile-version.
This check always fails during development or release:prepare
-DdryRun,
because it relies on tags and version numbers that are only available
when we are making a release for real. I committed a fix for
CALCITE-2385 [1] to fix this. I am not able to update the CI
configuration for Jenkins, but can someone update it to include the
-DskipDockerCheck argument to fix it?
For Travis, the cause of the test failures is also the same and I
updated the .travis.yml file to fix it.
[1] https://issues.apache.org/jira/browse/CALCITE-2385
