zhztheplayer commented on a change in pull request #1011: [CALCITE-2721]
Support parsing of DOT + MEMBER_FUNCTION
URL: https://github.com/apache/calcite/pull/1011#discussion_r255321779
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -3380,6 +3380,70 @@ SqlNode UnsignedNumericLiteralOrParam() :
{ return e; }
}
+/**
+ * Parse a row expression extended after an existing record type row expression
+ */
+SqlNode RowExpressionExtension() :
+{
+ final SqlNode e;
+ String p;
+}
+{
+ (
+ LOOKAHEAD( CompoundIdentifier() <LPAREN>)
Review comment:
Could you please check if following code works?
```java
{
(
e = NamedMemberFunctionCall()
|
p = Identifier() {
return new SqlIdentifier(p, getPos());
}
)
{ return e; }
}
```
The file `Parser.jj` tends to guarantee to generate a near LL(2) parser, any
change should aways avoid syntactic lookahead if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
