nerrve commented on a change in pull request #1043: [CALCITE-2552] : Support for column alias in order by clause for BigQuerySqlDialect and HiveSqlDialect URL: https://github.com/apache/calcite/pull/1043#discussion_r258460310
########## File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java ########## @@ -1168,8 +1185,8 @@ public Context withNullCollation(@Nonnull NullCollation nullCollation) { public Context withDataTypeSystem(@Nonnull RelDataTypeSystem dataTypeSystem) { return new ContextImpl(databaseProduct, databaseProductName, - databaseVersion, databaseMajorVersion, databaseMinorVersion, - identifierQuoteString, nullCollation, dataTypeSystem, jethroInfo); + databaseVersion, databaseMajorVersion, databaseMinorVersion, Review comment: Keep the continuation indent as 4. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services