[GitHub] stutigupta028 commented on a change in pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor dual table

[GitBox]

stutigupta028 commented on a change in pull request #1052: CALCITE-2833- Select 
without from support & CALCITE-2834-Support for values clause for dialects 
which neither have values clause nor dual table
URL: https://github.com/apache/calcite/pull/1052#discussion_r259298635
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java
 ##########
 @@ -58,16 +62,22 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
     case UNION:
       if (!((SqlSetOperator) call.getOperator()).isAll()) {
         SqlSyntax.BINARY.unparse(writer, UNION_DISTINCT, call, leftPrec, 
rightPrec);
+      } else {
+        super.unparseCall(writer, call, leftPrec, rightPrec);
       }
       break;
     case EXCEPT:
       if (!((SqlSetOperator) call.getOperator()).isAll()) {
         SqlSyntax.BINARY.unparse(writer, EXCEPT_DISTINCT, call, leftPrec, 
rightPrec);
+      } else {
+        super.unparseCall(writer, call, leftPrec, rightPrec);
 
 Review comment:
   Added test case for union all and made code changes for intersect and except 
.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services