[GitHub] kgyrtkirk commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs

[GitBox]

kgyrtkirk commented on a change in pull request #1053: [CALCITE-2852] 
Simplification: traverse calculations and unknown UDFs
URL: https://github.com/apache/calcite/pull/1053#discussion_r259525126
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
 ##########
 @@ -284,8 +284,24 @@ RexNode simplify(RexNode e, RexUnknownAs unknownAs) {
     case NOT_EQUALS:
       return simplifyComparison((RexCall) e, unknownAs);
     default:
+      if (e.getClass() == RexCall.class) {
+        return simplifyGenericNode((RexCall) e);
 
 Review comment:
   I really hope that we could keep an upper bound to visit at most every node 
twice even in the worst case - but I might be wrong

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services