kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257630221
########## File path: example/csv/src/test/resources/sales/MYDEPTS.csv ########## @@ -0,0 +1,9 @@ +DEPTNO:int,NAME:string +10,"Sales" + +20,"Marketing" +30,"Accounts" + + 31,"My Dept" +32, "My Another Depts" Review comment: I don't think this line should be accepted; the space seems to belong to a field which is the quoted - it becomes cloudy for me that this field is quoted or not ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
