danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260650033
########## File path: core/src/main/java/org/apache/calcite/sql/parser/SqlParserPos.java ########## @@ -125,6 +127,17 @@ public int getEndColumnNum() { return endColumnNumber; } + /** Mark this SqlParserPos as quoted and return itself. **/ + public SqlParserPos setQuoted(boolean quoted) { Review comment: @zhztheplayer I add the setQuoted in SqlIdentifier for the first commit, but Julian think SqlIdentifier is already a little complex and it's better to add in SqlParserPos, then we can quote just a position for composite identifier, e.g. a.`b`.c. You can see the details in the JIRA. For immutability, can you please give an example of the bad case of non-immutable SqlParserPos ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services