I would help to review some PRs this weekend，especially [1]. Hope to help and release some of the burden. [1] https://issues.apache.org/jira/browse/CALCITE-2018?jql=project%20%3D%20CALCITE%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20in%20(EMPTY%2C%20%22next%22)%20AND%20labels%20%3D%20pull-request-available%20ORDER%20BY%20priority%20DESC
Best, YuZhao Chan 在 2019年2月26日 +0800 AM8:14，Julian Hyde <jh...@apache.org>，写道： > Hey everyone. > > There are 108 open pull requests. What are we going to do about it? > > Last release I reviewed and committed dozens of pull requests, and I burned > out. > > Julian > > > > On Feb 22, 2019, at 1:20 PM, Kevin Risden <kris...@apache.org> wrote: > > > > Yea I don't mind pushing out the RC towards the end of next week (beginning > > of March). I'm not in a rush to build the RC. I just picked Monday to try > > to hit the target of February that was arbitrarily picked in the sand. At > > this point, the release will most likely happen in early March. > > > > Kevin Risden > > > > > > On Fri, Feb 22, 2019 at 4:15 PM Julian Hyde <jh...@apache.org> wrote: > > > > > Can you do the RC towards the end of next week? > > > > > > I only just saw this message - 4 days after you sent it - because I’ve > > > been fighting down a backlog of 500 Apache messages. There are some > > > changes > > > I would like to get into the release but I will need a few days. > > > > > > Julian > > > > > > > > > > On Feb 18, 2019, at 9:56 AM, > > > Kevin Risden > > > <kris...@apache.org> wrote: > > > > > > > > It looks like there are some PRs to be reviewed and some changes to get > > > > merged in this week. > > > > > > > > How does creating the first RC on Monday Feb 25th sound? Does that give > > > > enough time this week to get changes into Calcite 1.19.0? > > > > > > > > Kevin Risden > > > > > > > > > > > > On Wed, Feb 13, 2019 at 11:08 AM Zoltan Haindrich <k...@rxd.hu> wrote: > > > > > > > > > > > > > > On 2/13/19 4:24 PM, Julian Hyde wrote: > > > > > > Sorry, there’s been a misunderstanding. Let me clarify. I didn’t say > > > > > that your patches were too small. Or intend to imply it. > > > > > > > > > > > > When I said “widespread changes for no good reason” - or something > > > > > > like > > > > > that - I meant changes to the RexNode format due to removing IS TRUE > > > nodes. > > > > > > > > > > > > I like small patches, provided each one fixes a well defined issue > > > > > > and > > > > > has appropriate tests. > > > > > > > > > > From now on I will try to provide a testcase when opening the jira. > > > > > Sorry for the misunderstanding, thank you for making it clear! > > > > > > > > > > > > > > > > > Julian > > > > > > > > > > > > > On Feb 13, 2019, at 3:40 AM, Zoltan Haindrich <k...@rxd.hu> wrote: > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > In Hive I'm a little bit behind in upgrading to 1.18 and although > > > > > > > the > > > > > upgrade would not cause any correctness issues; but in a sense it's > > > > > more > > > > > conservative in doing some simplifications - which could be > > > > > interpreted > > > as > > > > > regressions; if we take that into account that even the plan could get > > > > > worse. > > > > > > > > > > > > > > I've a few patches almost ready - they are very small changes > > > (actually > > > > > Julian mentioned that they are kinda too small, so next time I will > > > > > not > > > be > > > > > opening separate jiras for them) > > > > > > > > > > > > > > I will finish them and launch a custom Hive test with the latest > > > master > > > > > to see if there are any new issues coming from that direction. > > > > > > > I should get the results for it by tomorrow. > > > > > > > > > > > > > > cheers, > > > > > > > Zoltan > > > > > > > > > > > > > > > > > > > > > > On 2/12/19 11:30 PM, Stamatis Zampetakis wrote: > > > > > > > > I was not suggesting changing the release process. I wanted > > > > > > > > just to > > > > > > > > highlight the fact that if the aforementioned tickets are not > > > > > > > > part of > > > > > 1.19 > > > > > > > > I will have to create an unofficial bundle which includes them > > > > > > > > in > > > > > order to > > > > > > > > keep the downstream project working. Sorry for the confusion. > > > > > > > > Στις Τρί, 12 Φεβ 2019 στις 8:56 μ.μ., ο/η Julian Hyde < > > > > > jh...@apache.org> > > > > > > > > έγραψε: > > > > > > > > > Stamatis, > > > > > > > > > > > > > > > > > > We’ve so far managed to avoid making patch releases. It keeps > > > > > > > > > life > > > > > simpler > > > > > > > > > if all releases are from the main line. And simple is > > > > > > > > > important, > > > > > given that > > > > > > > > > there are no salaried release or QA engineers working on > > > > > > > > > Calcite. > > > > > > > > > > > > > > > > > > But as part of that contract, we commit to making releases > > > > > > > > > from main > > > > > line > > > > > > > > > frequently and regularly. Hopefully 1.19 will arrive soon > > > > > > > > > enough for > > > > > your > > > > > > > > > purposes. > > > > > > > > > > > > > > > > > > Julian > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Feb 12, 2019, at 5:27 AM, Stamatis Zampetakis < > > > zabe...@gmail.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > In order to enable Calcite on a downstream project I need > > > > > > > > > > to patch > > > > > > > > > > the official release with the PRs of the following Jiras. > > > > > > > > > > > > > > > > > > > > [CALCITE-2464] Allow to set nullability for columns of > > > > > > > > > > structured > > > > > types > > > > > > > > > [1] > > > > > > > > > > [CALCITE-2677] Struct types with one field are not mapped > > > > > > > > > > correctly > > > > > to > > > > > > > > > Java > > > > > > > > > > Classes [2] > > > > > > > > > > [CALCITE-2776] Wrong value when accessing struct types with > > > > > > > > > > one > > > > > attribute > > > > > > > > > > [3] > > > > > > > > > > > > > > > > > > > > I think the discussion has advanced quite a lot for > > > > > > > > > > CALCITE-2464 > > > so I > > > > > > > > > could > > > > > > > > > > probably take it on my self, > > > > > > > > > > but I would really appreciate some input regarding > > > > > > > > > > CALCITE-2677 and > > > > > > > > > > CALCITE-2776. > > > > > > > > > > Let's continue the discussion under the respective Jiras. > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > Stamatis > > > > > > > > > > > > > > > > > > > > [1] https://jira.apache.org/jira/browse/CALCITE-2464 > > > > > > > > > > [2] https://jira.apache.org/jira/browse/CALCITE-2677 > > > > > > > > > > [3] https://jira.apache.org/jira/browse/CALCITE-2776 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Στις Δευ, 11 Φεβ 2019 στις 9:49 μ.μ., ο/η Francis Chuang < > > > > > > > > > > francischu...@apache.org> έγραψε: > > > > > > > > > > > > > > > > > > > > > Thanks for getting this started, Kevin! > > > > > > > > > > > > > > > > > > > > > > On 12/02/2019 6:39 am, Julian Hyde wrote: > > > > > > > > > > > > > > Are there any JIRA cases that should make it into > > > > > > > > > > > > > > 1.19.0 but > > > are > > > > > not > > > > > > > > > > > yet > > > > > > > > > > > > > > finished? > > > > > > > > > > > > > > > > > > > > > > > > Yes - there are a lot cases that have a PR ready that > > > > > > > > > > > > have not > > > been > > > > > > > > > > > reviewed / committed. We, the committers, will need to > > > > > > > > > > > make a team > > > > > > > > > effort > > > > > > > > > > > to get as many of these in as possible. > > > > > > > > > > > > > > > > > > > > > > > > Julian > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Feb 11, 2019, at 11:05 AM, Michael Mior > > > > > > > > > > > > > <mm...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks for getting the ball rolling Kevin! > > > > > > > > > > > > > -- > > > > > > > > > > > > > Michael Mior > > > > > > > > > > > > > mm...@apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > Le lun. 11 févr. 2019 à 09:51, > > > > > Kevin Risden > > > > > <kris...@apache.org> a > > > > > > > > > > > écrit : > > > > > > > > > > > > > > > > > > > > > > > > > > > > Calcite 1.18.0 was released on 2018-12 (coming up > > > > > > > > > > > > > > on 2 months > > > > > ago). > > > > > > > > > It > > > > > > > > > > > is > > > > > > > > > > > > > > time to get the ball rolling for the Calcite 1.19.0 > > > > > > > > > > > > > > release > > > since > > > > > > > > > there > > > > > > > > > > > > > > have been releases every 2-3 months. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Calcite currently has 32 JIRA issues tagged for > > > > > > > > > > > > > > 1.19.0 with 68 > > > > > > > > > commits. > > > > > > > > > > > > > > Avatica currently has 2 JIRA issues tagged for > > > > > > > > > > > > > > avatica-1.14.0 > > > > > with 8 > > > > > > > > > > > > > > commits. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Are there any JIRA cases that should make it into > > > > > > > > > > > > > > 1.19.0 but > > > are > > > > > not > > > > > > > > > > > yet > > > > > > > > > > > > > > finished? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Since there are only two minor commits to Avatica I > > > > > > > > > > > > > > don't think > > > > > we > > > > > > > > > > > need a > > > > > > > > > > > > > > new Avatica release before the Calcite release. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Kevin Risden > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
