Hi Stamatis,

Yes, if it works for you then I'll try to track that down and file a Jira.

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Von: Stamatis Zampetakis
An: dev@calcite.apache.org
Cc:

Thanks for raising this Julian.

I tested today on MacOS Mojave (10.14.5) and jdk 1.8.0_111 and build (mvnw
install) finishes without errors.

I guess the problem you raised is related to your local environment.

Can you please log a JIRA with more details on what happens?
Can you also check if this is a regression from 1.20.0?

Best,
Stamatis

On Mon, Sep 2, 2019, 9:32 PM Julian Feinauer <j.feina...@pragmaticminds.de>
wrote:

> Hi Stamatis,
>
> thank you for your effort!
>
> Unfortunately, I think I have to vote
>
> -1 (non-binding)
>
> as I encountered an issue building the artefacts with the given
> instruction (see below).
> But as my vote is non-binding it's up to the more experienced devs to
> decide how to handle this case exactly.
> I am not sure on how to interpret the policy [1] in that case.
>
> I also found some minor issues I described below.
>
> I checked:
> - Checksum and Signature correct
> - Checked LICENSE and NOTICE
> - Run build as described in "howto.md" (mvnw install) on "java version
> "1.8.0_181" (Hotspot) on OS X fails (see below)
> - Run build as "mvnw install -DskipTests" succeeds
> - Checked no unexpected binaries
>
> Issues:
> - I am unable to build the package (see above) as the following tests fail:
>
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR]   OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while
> parsing value [0...
> [ERROR]   OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL
> "select disti...
> [INFO]
> [ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24
>
> Minor Issues:
> - README is not up to date as it says that README.md contains "examples of
> running calcite" which it doesn’t
> - Information on how to build the project is only available on the
> homepage not in one of the readmes or doc files (a link to "howto.md" in
> the README or README.md would be good, I think)
>
> Best
> Julian
>
> [1] https://apache.org/legal/release-policy.html
>
> Am 02.09.19, 17:16 schrieb "Stamatis Zampetakis" <zabe...@gmail.com>:
>
>     Hi all,
>
>     I have created a build for Apache Calcite 1.21.0, release candidate 0.
>
>     Thanks to everyone who has contributed to this release.
>
>     This release comes two months after 1.20.0 and brings many bug fixes
> and
>     new
>     important features among others the following.
>
>     * Support for implicit casts.
>     * Transformation of Pig Latin scripts to calcite plans.
>     * Implementation for MATCH_RECOGNIZE and its basic features.
>     * Support for correlated ANY/SOME/ALL subqueries.
>     * New join algorithm implementations.
>
>     You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md
>
>     The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4420139600bb68f8568c4b1c960ad4dbcb1a43f1
>
>     Its hash is 4420139600bb68f8568c4b1c960ad4dbcb1a43f1.
>
>     The artifacts to be voted on are located here:
>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc0/
>
>     The hashes of the artifacts are as follows:
>     src.tar.gz.sha256
>     f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f33334e
>
>     A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1066
>
>     Release artifacts are signed with the following key:
>     http://home.apache.org/~zabetak/zabetak.asc
>     https://people.apache.org/keys/committer/zabetak.asc (in the next LDAP
>     refresh)
>
>     Please vote on releasing this package as Apache Calcite 1.21.0.
>
>     The vote is open for the next 72 hours and passes if a majority of
>     at least three +1 PMC votes are cast.
>
>     [ ] +1 Release this package as Apache Calcite 1.21.0
>     [ ]  0 I don't feel strongly about it, but I'm okay with the release
>     [ ] -1 Do not release this package because...
>
>
>     Here is my vote:
>
>     +1 (binding)
>
>     Stamatis
>
>
>

Reply via email to