Julian Hyde created CALCITE-3327: ------------------------------------ Summary: Simplify SqlValidatorTest by replacing 'boolean typeCoercion' parameter with fluent method 'Sql.withTypeCoercion(boolean)' Key: CALCITE-3327 URL: https://issues.apache.org/jira/browse/CALCITE-3327 Project: Calcite Issue Type: Bug Reporter: Julian Hyde
Simplify SqlValidatorTest by replacing {{boolean typeCoercion}} parameter with fluent method {{withTypeCoercion(boolean)}} in class {{SqlValidatorTestCase.Sql}}. The problem with the {{boolean typeCoercion}} parameter is that it doesn't compose with all of the other flags we might want to pass - are we testing a query or an expression?, is it supposed to pass or fail?, does it contain window functions? - and therefore we have to add it in a combinatorial number of places. Fluent interfaces are preferred over "test methods" like {{checkExpFails}} for big tests like {{SqlValidatorTest}}. I'm developing a fix, and I'll post the branch URL shortly. -- This message was sent by Atlassian Jira (v8.3.2#803003)