+1 (binding) Checked LICENSE, NOTICE, checksums, compiled and ran tests on JDK 11/Ubuntu, ran RAT. Checked that tar contents match git commit.
One minor thing: I was surprised that commit adc1532de does not have tag calcite-1.21.0. Not a blocker for the release, but worth fixing. The release notes are written in passive voice (e.g. “The parser has been enhanced …”). Consider converting to active voice; it makes it more direct. (Scientific writing requires passive voice, but the rest of the world is agreed that active voice is superior.) If you need a subject for the sentence, use “Calcite”, e.g. “Calcite now parses…”. Also, please put back-ticks around SQL keywords like MATCH_RECOGNIZE or java types like SemiJoin. Not a blocker for the release; can be fixed afterwards. I want to say thank you to non-committers like Anton for voting on the release. You are an important part of our quality control, so your time & diligence is appreciated. Julian > On Sep 9, 2019, at 7:55 AM, Julian Feinauer <j.feina...@pragmaticminds.de> > wrote: > > Hi Stamatis, > > thank you for your effort! > > +1 (non-binding) > > I found some minor issues I described below and the failing Test from the > last RC but as its addressed for the next release, so I think it's reasonable > addressed. > > I checked: > - Checksum and Signature correct > - Checked LICENSE and NOTICE > - Checked diff between rc0 / rc1 as expected (no pom.xml.??? files) > - Run build as described in "howto.md" (mvnw install) on "java version > "1.8.0_181" (Hotspot) on OS X fails (see below) > - Run build as "mvnw install" exceeds if OsAdapterTest is removed > - Checked no unexpected binaries > - Checked License headers with rat > > Minor Issues: > - README is not up to date as it says that README.md contains "examples of > running calcite" which it doesn’t > - Information on how to build the project is only available on the homepage > not in one of the readmes or doc files (a link to "howto.md" in the README or > README.md would be good, I think) > > Test fails: > - As expected the OsAdapterTest has some issues (see CALCITE-2816) > [INFO] Results: > [INFO] > [ERROR] Errors: > [ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while > parsing value [0... > [ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL > "select disti... > [INFO] > [ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24 > > - In one run the following fails, but succeeds at second run. I log a jira if > it ever happens again (checked in IDE and worked fine there) > [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 4.375 > s <<< FAILURE! - in org.apache.calcite.test.PigRelBuilderStyleTest > [ERROR] > testImplWithCountWithoutGroupBy(org.apache.calcite.test.PigRelBuilderStyleTest) > Time elapsed: 2.712 s <<< ERROR! > org.apache.pig.impl.logicalLayer.FrontendException: Unable to open iterator > for alias t > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: org.apache.pig.PigException: Unable to store alias t > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: org.apache.pig.impl.logicalLayer.FrontendException: Error > processing rule LoadTypeCastInserter > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: java.lang.NullPointerException > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > > Julian > > Am 09.09.19, 02:02 schrieb "Anton Haidai" <anton.hai...@gmail.com>: > > Hello, > > Local Calcite build with tests enabled on Linux: OK > Calcite-based system (Zoomdata) test suite: OK > > +1 (non-binding) > > On Fri, Sep 6, 2019 at 7:42 PM Stamatis Zampetakis <zabe...@gmail.com> > wrote: > >> Hi all, >> >> I have created a build for Apache Calcite 1.21.0, release candidate 1. >> >> Thanks to everyone who has contributed to this release. >> >> Since RC 0, we have fixed the following issues: >> * [CALCITE-3322] Remove duplicate test case in RelMetadataTest (沈洪) >> * [CALCITE-3321] BigQuery does not have correct casing rules (Lindsey >> Meyer) >> * Remove the useless JdbcConvention out in descriptionPrefix for >> JdbcToEnumerableConverterRule >> * Removed spurious *.xml.xxx files from the release artifacts >> >> You can read the release notes here: >> https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md >> >> The commit to be voted upon: >> >> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=adc1532de853060d24fd0129257a3fae306fb55c >> >> Its hash is adc1532de853060d24fd0129257a3fae306fb55c. >> >> The artifacts to be voted on are located here: >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc1/ >> >> The hashes of the artifacts are as follows: >> src.tar.gz.sha256 >> f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f33334e >> >> A staged Maven repository is available for review at: >> https://repository.apache.org/content/repositories/orgapachecalcite-1067 >> >> Release artifacts are signed with the following key: >> https://people.apache.org/keys/committer/zabetak.asc >> >> Please vote on releasing this package as Apache Calcite 1.21.0. >> >> The vote is open for the next 96 hours (due to the weekend) and passes if a >> majority of >> at least three +1 PMC votes are cast. >> >> [ ] +1 Release this package as Apache Calcite 1.21.0 >> [ ] 0 I don't feel strongly about it, but I'm okay with the release >> [ ] -1 Do not release this package because... >> >> >> Here is my vote: >> >> +1 (binding) >> > > > -- > Best regards, > Anton. > >
