I have mixed feelings about this, because on one hand, I'd like to have these things corrected but on the other hand, we're already bogged down with PRs. Perhaps a good compromise is to make it clear that a JIRA should not be created and have some type of tag indicated in the title of the PR. This might be a good time to create a pull request template for GitHub that explains some of the policies (e.g. making sure that non-trivial changes DO have a JIRA case). -- Michael Mior mm...@apache.org
Le mer. 25 sept. 2019 à 20:42, Julian Hyde <jh...@apache.org> a écrit : > > I noticed this exchange in https://github.com/apache/calcite/pull/1475: > <https://github.com/apache/calcite/pull/1475:> > > > > Q. Just curious, does Calcite accept hotfix style PR that fixes typos, > > comments, etc.? > > > A. As long as they are large enough. But for 1 line typo fix, it is not > > worth a specific patch, we prefer to accumulate them together. > > This is indeed our current position. And the reason we have given is that it > takes considerable effort to review and commit a pull request, even a small > one. > > Should we reconsider this position? > > Julian
