Hello everyone,

- Local Calcite build with tests (Windows10 + JDK8): OK
- Calcite-based application test suite: OK

However, the patch to correct the issue on RC0 [1] is a breaking change
(for some scenarios) that introduced a regression in my downstream project
that required a (temporary) quick-fix [2] (thanks Haisheng Yuan for your
help and reactivity). There is still some discussion going on in the Jira
ticket [1], and even though I am not 100% convinced on the direction that
was taken, I cannot provide a better alternative at this time (and in any
case with the quick-fix this is not a blocking issue on my side).
+0 (non binding)

Best regards,
Ruben

[1] https://issues.apache.org/jira/browse/CALCITE-3997
[2]
https://github.com/apache/calcite/commit/05376d6bff11ccef690addb4f9c40ab16dd20bec



Le sam. 16 mai 2020 à 06:02, Haisheng Yuan <hy...@apache.org> a écrit :

> Hi all,
>
> I have created a build for Apache Calcite 1.23.0, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> (revision 39622)
>
> The hashes of the artifacts are as follows:
>
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> *apache-calcite-1.23.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/release/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.23.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.23.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>

Reply via email to