+1 (non-binding). - run tests locally: ok - verify the commit hash in git tag: ok - check sha512: ok
Environment: - java version 1.8.0_151 - MacOS Mojave 10.14.6 BTW, It shows 404 when I open https://apache.github.io/calcite-site-preview/docs/history.html. On Mon, Aug 10, 2020 at 9:47 AM Rui Wang <amaliu...@apache.org> wrote: > > I'm happy to change release notes to better reflect 1.25.0 changes. I > > presume it can be done after the vote ? > > Absolutely! It does not affect current vote. > > > -Rui > > On Sun, Aug 9, 2020 at 4:55 PM Andrei Sereda <and...@sereda.cc> wrote: > > > > one thing can be fixed after vote: CALCITE-4114 does not belong to > > "breaking changes" in the release note. > > > > I'm happy to change release notes to better reflect 1.25.0 changes. I > > presume it can be done after the vote ? > > > > On Sun, Aug 9, 2020 at 7:39 PM Francis Chuang <francischu...@apache.org> > > wrote: > > > > > Thanks for making this release available for voting, Andrei! > > > > > > Verified GPG Signature - OK > > > Verified SHA512 - OK > > > Ran tests per HOWTO (./gradlew check) - OK > > > Quickly skimmed release notes > > > ( > > > > > > https://github.com/apache/calcite/blob/calcite-1.25.0-rc0/site/_docs/history.md > > ) > > > > > > - OK > > > Spotted checked a few JARs in the Maven repository - OK > > > > > > Environment (OpenJDK:latest docker container): > > > Gradle 6.3 (via gradlew) > > > Oracle Linux Server 7.8 > > > openjdk 14.0.2 2020-07-14 > > > OpenJDK Runtime Environment (build 14.0.2+12-46) > > > OpenJDK 64-Bit Server VM (build 14.0.2+12-46, mixed mode, sharing) > > > > > > My vote is: +1 (binding) > > > > > > Francis > > > > > > On 10/08/2020 4:10 am, Rui Wang wrote: > > > > +1 (non-binding) > > > > > > > > platform: ubuntu16 + java8 > > > > > > > > run tests locally on: ok > > > > verify the commit hash in git tag: ok > > > > check sha512: ok > > > > verify signature by gpg: ok > > > > > > > > > > > > one thing can be fixed after vote: CALCITE-4114 does not belong to > > > > "breaking changes" in the release note. That change happened in > > core/test > > > > (a testing related change). > > > > > > > > > > > > -Rui > > > > > > > > > > > > > > > > On Sun, Aug 9, 2020 at 2:02 AM Enrico Olivelli <eolive...@gmail.com> > > > wrote: > > > > > > > >> +1 (non binding) > > > >> run tests locally on Fedora + JDK14 > > > >> run tests of HerdDB just by switching from 1.24 without any change > > > >> > > > >> Enrico > > > >> > > > >> Il giorno dom 9 ago 2020 alle ore 05:22 Andrei Sereda > > <and...@sereda.cc > > > > > > > >> ha > > > >> scritto: > > > >> > > > >>> Hi all, > > > >>> > > > >>> I have created a build for Apache Calcite 1.25.0, release > > > >>> candidate 0. > > > >>> > > > >>> Thanks to everyone who has contributed to this release. > > > >>> > > > >>> You can read the release notes here: > > > >>> https://apache.github.io/calcite-site-preview/docs/history.html > > > >>> > > > >>> The commit to be voted upon: > > > >>> > > > >>> > > > >> > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=68b02dfd4af15bc94a91a0cd2a30655d04439555 > > > >>> > > > >>> Its hash is 68b02dfd4af15bc94a91a0cd2a30655d04439555 > > > >>> > > > >>> Tag: > > > >>> https://github.com/apache/calcite/tree/calcite-1.25.0-rc0 > > > >>> > > > >>> The artifacts to be voted on are located here: > > > >>> > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.25.0-rc0 > > > >>> (revision 40922) > > > >>> > > > >>> RAT report: > > > >>> https://apache.github.io/calcite-site-preview/rat/rat-report.txt > > > >>> > > > >>> Site preview is here: > > > >>> https://apache.github.io/calcite-site-preview/ > > > >>> > > > >>> JavaDoc API preview is here: > > > >>> https://apache.github.io/calcite-site-preview/api > > > >>> > > > >>> The hashes of the artifacts are as follows: > > > >>> > > > >>> > > > >> > > > > > > a5e61bd93657a274ee8a1d1ecbde68e3e471fd27b85bea179991b372f094ae3cdf692672245506a08b996534f9136be26569de81af2bb7d8f026799313957e87 > > > >>> *apache-calcite-1.25.0-src.tar.gz > > > >>> > > > >>> A staged Maven repository is available for review at: > > > >>> > > > >>> > > > >> > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1097/org/apache/calcite/ > > > >>> > > > >>> Release artifacts are signed with the following key: > > > >>> https://people.apache.org/keys/committer/sereda.asc > > > >>> https://www.apache.org/dist/calcite/KEYS > > > >>> > > > >>> N.B. > > > >>> To create the jars and test Apache Calcite: "./gradlew build". > > > >>> > > > >>> If you do not have a Java environment available, you can run the > > tests > > > >>> using docker. To do so, install docker and docker-compose, then run > > > >>> "docker-compose run test" from the root of the directory. > > > >>> > > > >>> Please vote on releasing this package as Apache Calcite 1.25.0. > > > >>> > > > >>> The vote is open for the next 72 hours and passes if a majority of > at > > > >>> least three +1 PMC votes are cast. > > > >>> > > > >>> [ ] +1 Release this package as Apache Calcite 1.25.0 > > > >>> [ ] 0 I don't feel strongly about it, but I'm okay with the > release > > > >>> [ ] -1 Do not release this package because... > > > >>> > > > >>> > > > >>> Here is my vote: > > > >>> > > > >>> +1 (non binding) > > > >>> > > > >> > > > > > > > > > >
