James Starr created CALCITE-4546: ------------------------------------ Summary: No Longer require RelNode subtype registration for Metadata Key: CALCITE-4546 URL: https://issues.apache.org/jira/browse/CALCITE-4546 Project: Calcite Issue Type: Improvement Components: core Reporter: James Starr
Using JdbcTest.testJoinFiveWay, I ran the query six times then I took the last 3 results as reported by intellij. I then repeated this 3 times. After bench marking Janio, my prototype and using legacy java reflections, I found: | |Janio||*Prototype*||*java reflection*|| |Average|326.4444444|315.5555556|1525.888889| |Standard Deviation|27.12983188|14.75729575|75.8476177| The prototype was a static code with out caching or cycle detection. I latter added cycle detection and caching, but the results were with in one standard deviation. So I didn't not follow up further. I was doing the dispatch with instance of instead of scanning an array of known classes. {code:java} if(node instanceof ...){ return handler.call((...) node); } else if(node instanceof ...) { return handler.call((...) node); }.... {code} If janino compiler dispatch was changed to use instanceof, it would remove the requirement know all relnode subtypes. -- This message was sent by Atlassian Jira (v8.3.4#803005)