Julian Hyde created CALCITE-4671:
------------------------------------

             Summary: Allow Avatica connect-string properties in any case 
(lowerCamel, UPPER_SNAKE, etc.)
                 Key: CALCITE-4671
                 URL: https://issues.apache.org/jira/browse/CALCITE-4671
             Project: Calcite
          Issue Type: Bug
          Components: avatica
            Reporter: Julian Hyde


Avatica's built-in properties are mostly lower_snake case (e.g. 
{{truststore_password}}; the one exception being {{timeZone}} in lowerCamel; 
see [client 
reference|https://calcite.apache.org/avatica/docs/client_reference.html]); 
Calcite's built-in properties are lowerCamel case (e.g. 
[approximateTopN|https://calcite.apache.org/javadocAggregate/org/apache/calcite/config/CalciteConnectionProperty.html#APPROXIMATE_TOP_N];
 see [Calcite JDBC driver 
reference|https://calcite.apache.org/docs/adapter.html#jdbc-connect-string-parameters%C2%A0]).
 Avatica's properties are inherited by Calcite, so there is bound to be 
confusion.

Avatica's connect string parser (also used in Calcite) should allow any case. 
Thus {{truststore_password}}, {{truststorePassword}}, {{TRUSTSTORE_PASSWORD}}, 
{{TruststorePassword}} are all acceptable. {{trustStorePassword}} is not 
acceptable, because "truststore" is one word.

In Calcite and Avatica doc, add a note that properties can are accepted in any 
case.

Change Avatica's properties to lowerCamel case in both doc and code. (The old 
forms, e.g. "truststore_password", will continue to work.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to