+1 (non-binding), thanks Julian for preparing the RC!
-) Checked hash and signature: OK
-) Checked release notes: OK (but NoboGo should be NobiGo I think)
-) Checked the release tag with right commit: OK
-) Checking the tag and the tar.gz content: OK
diff -qr apache-calcite-avatica-1.19.0-src ~/git/calcite-avatica:
usual diff on LICENCE etc., same as what Stamatis reported for the last
release
-) Visual inspection of the links provided in the email: OK
-) ./gradlew build (after copying the wrapper and content of "gradle"
folder from the git clone) --> OK
tested the following combinations:
sdks=( 8.0.292.hs-adpt 8.302.08.1-amzn 11.0.2-open 8.0.302-tem 8.0.302-zulu
)
timezones=(America/New_York UTC GMT Europe/Paris America/Los_Angeles)
guavas=(19.0 20.0 21.0 22.0 23.6.1-jre 24.1.1-jre 25.1-jre 26.0-jre
27.1-jre 28.2-jre 29.0-jre 30.1.1-jre);
The details about JVMs, gradle, and OS versions are as follows:
$ java -version (8.0.292.hs-adpt)
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
$ java -version (8.302.08.1-amzn)
openjdk version "1.8.0_302"
OpenJDK Runtime Environment Corretto-8.302.08.1 (build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM Corretto-8.302.08.1 (build 25.302-b08, mixed mode)
$ java -version (11.0.2-open)
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
$ java -version (8.0.302-tem)
openjdk version "1.8.0_302"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM (Temurin)(build 25.302-b08, mixed mode)
$ java -version (8.0.302-zulu)
openjdk version "1.8.0_302"
OpenJDK Runtime Environment (Zulu 8.56.0.21-CA-macosx) (build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM (Zulu 8.56.0.21-CA-macosx) (build 25.302-b08,
mixed mode)
$ sw_vers
ProductName: macOS
ProductVersion: 11.6
BuildVersion: 20G165
$ ./gradlew -version
------------------------------------------------------------
Gradle 6.8.1
------------------------------------------------------------
Build time: 2021-01-22 13:20:08 UTC
Revision: 31f14a87d93945024ab7a78de84102a3400fa5b2
Kotlin: 1.4.20
Groovy: 2.5.12
Ant: Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM: 1.8.0_292 (AdoptOpenJDK 25.292-b10)
OS: Mac OS X 10.16 x86_64
Best regards,
Alessandro
On Wed, 6 Oct 2021 at 04:42, Francis Chuang <francischu...@apache.org>
wrote:
> My vote is: +1 (Thanks Julian!)
>
> - Verified GPG signature - OK
> - Verified SHA512 - OK
> - Checked release notes on stage branch
> (
> https://github.com/apache/calcite-avatica/blob/stage/site/_docs/history.md)
>
> - OK
> - Ran tests (gradle test) - OK
> - Spot checked Nexus artifacts - OK
>
> Notes:
> - The build fails when using Gradle 7.2, maybe we should upgrade for the
> next release (1.20.0).
> - I noticed the use of the stage branch for this release. Can you
> document it for the next release manager after this release is finalized?
>
> Environment:
> Gradle 6.9.1 docker container in WSL2 (Ubuntu 20.04) on Windows 10 21h1
>
> > docker version
> Client: Docker Engine - Community
> Cloud integration: 1.0.17
> Version: 20.10.8
> API version: 1.41
> Go version: go1.16.6
> Git commit: 3967b7d
> Built: Fri Jul 30 19:54:22 2021
> OS/Arch: linux/amd64
> Context: default
> Experimental: true
>
> Server: Docker Engine - Community
> Engine:
> Version: 20.10.8
> API version: 1.41 (minimum version 1.12)
> Go version: go1.16.6
> Git commit: 75249d8
> Built: Fri Jul 30 19:52:31 2021
> OS/Arch: linux/amd64
> Experimental: false
> containerd:
> Version: 1.4.9
> GitCommit: e25210fe30a0a703442421b0f60afac609f950a3
> runc:
> Version: 1.0.1
> GitCommit: v1.0.1-0-g4144b63
> docker-init:
> Version: 0.19.0
> GitCommit: de40ad0
>
> > gradle -v
>
> ------------------------------------------------------------
> Gradle 6.9.1
> ------------------------------------------------------------
>
> Build time: 2021-08-20 11:15:18 UTC
> Revision: f0ddb54aaae0e44f0a7209c3c0274d506ea742a0
>
> Kotlin: 1.4.20
> Groovy: 2.5.12
> Ant: Apache Ant(TM) version 1.10.9 compiled on September 27 2020
> JVM: 1.8.0_292 (AdoptOpenJDK 25.292-b10)
> OS: Linux 5.10.16.3-microsoft-standard-WSL2 amd64
>
> > java -version
> openjdk version "1.8.0_292"
> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
>
> Francis
>
> On 6/10/2021 1:15 pm, Julian Hyde wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite Avatica 1.19.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release. And thank you
> > to Francis, Vladimir and Stamatis for assistance with the release
> process.
> >
> > You can read the release notes here:
> >
> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/docs/history.html
> >
> > The commit to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=d9f437424709fc6d7944dba174a658a7ca83e792
> >
> > Its hash is d9f437424709fc6d7944dba174a658a7ca83e792
> >
> > Tag:
> >
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.19.0-rc0
> >
> > The artifacts to be voted on are located here:
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.19.0-rc0
> > (revision 50284)
> >
> > RAT report:
> >
> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt
> >
> > Site preview is here:
> >
> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/
> >
> > JavaDoc API preview is here:
> >
> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api
> >
> > The hashes of the artifacts are as follows:
> >
> eb097a4638e521ea58e0736ba2b0546bef58ec602c021b381191fdea10ca8855b297b645bf58488698aa21aa30c691e00219bb5dbdf737655ca23f35b83e6aa5
> > *apache-calcite-avatica-1.19.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1119/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jhyde.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > To create the jars and test Apache Calcite Avatica: "gradle build
> > -Prelease -PskipSign".
> >
> > If you do not have a Java/Gradle environment available, you can run the
> tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite Avatica 1.19.0.
> >
> > The vote is open until at least October 9th at 0300 UTC (72 hours from
> now)
> > and passes if a majority of at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite Avatica 1.19.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Julian
> >
>
