Hi everyone,
my vote is +1 (non-binding) after checking the RC as follows:
- Checked hash and signature: OK
- Checked release notes: OK
- Checked the release tag with right commit: OK
- Checking the tag and the tar.gz content: OK
diff -qr apache-calcite-avatica-1.20.0-src ~/git/calcite-avatica:
.trash spurious folder as noticed by Stamatis
- Visual inspection of the links provided in the email: OK
- ./gradlew build (after copying the wrapper and content of "gradle" folder
from the git clone) --> OK
The details about JVMs, gradle, and OS versions are as follows:
$ java -version (8.0.292.hs-adpt)
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
$ sw_vers
ProductName: macOS
ProductVersion: 11.6
BuildVersion: 20G165
$ ./gradlew -version
------------------------------------------------------------
Gradle 6.8.1
------------------------------------------------------------
Build time: 2021-01-22 13:20:08 UTC
Revision: 31f14a87d93945024ab7a78de84102a3400fa5b2
Kotlin: 1.4.20
Groovy: 2.5.12
Ant: Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM: 1.8.0_292 (AdoptOpenJDK 25.292-b10)
OS: Mac OS X 10.16 x86_64
Best regards,
Alessandro
On Mon, 13 Dec 2021 at 13:43, Stamatis Zampetakis <zabe...@gmail.com> wrote:
> Apologies for holding back the first vote due to CALCITE-4935, I misjudged
> the situation.
>
> Ubuntu 20.04.3 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 6.8.3
>
> * Checked signatures and checksums OK
> * Went over release note OK
> * Built from git tag and run tests (./gradlew clean build) OK
> * Built from source artifacts and run tests (gradle clean build) OK
> * Checked diff between repo and artifacts OK
> There is an empty .trash directory in sources (and not in git) but it's
> minor and shouldn't block the release.
>
> +1 (binding)
>
> Best,
> Stamatis
>
> On Mon, Dec 13, 2021 at 5:01 AM Francis Chuang <francischu...@apache.org>
> wrote:
>
> > +1 (binding) as per my vote in the previous vote thread.
> >
> > Francis
> >
> > On 13/12/2021 2:05 pm, Jacques Nadeau wrote:
> > > +1 (binding).
> > >
> > > RC0 looks good to me (built/tested/verified) and I agree that
> > CALCITE-4935
> > > is not a release blocker.
> > >
> > > On Sun, Dec 12, 2021 at 6:45 PM Julian Hyde <jh...@apache.org> wrote:
> > >
> > >> Hi all,
> > >>
> > >> Yesterday I started a vote for Apache Calcite Avatica 1.20.0, release
> > >> candidate 0, and then canceled it due to CALCITE-4935. (See
> > >> https://issues.apache.org/jira/browse/CALCITE-4935.) Note that the
> > >> subject of this email ends "(release candidate 0) (second vote)".
> > >>
> > >> The artifacts are the same, but we have new information, namely the
> > >> discussion about whether CALCITE-4935 is a show-stopper. My judgment,
> > >> as release manager, that it is not a show-stopper, and therefore
> > >> release candidate 0 is good. I have restarted the vote because I would
> > >> like to give you all a chance to weigh in.
> > >>
> > >> This vote does NOT carry forward votes from the previous thread. If
> > >> you voted yesterday, please vote again.
> > >>
> > >> The remainder of this email is the same as yesterday's email, except
> > >> "The vote is open for the next 18 hours".
> > >>
> > >>
> > >> You can read the release notes here:
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/docs/history.html
> > >>
> > >> The commit to be voted upon:
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=8f8377551e7b07dbc6119ecf196942bc99834452
> > >>
> > >> Its hash is 8f8377551e7b07dbc6119ecf196942bc99834452
> > >>
> > >> Tag:
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.20.0-rc0
> > >>
> > >> The artifacts to be voted on are located here:
> > >>
> > >>
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.20.0-rc0
> > >> (revision 51334)
> > >>
> > >> The hashes of the artifacts are as follows:
> > >>
> > >>
> >
> 2de57fb1823237ec2d73f2e26059b6a7f5f51ec8f6dcfdcb2eb0b562cf4ef141c4a0a8c430610815e85b0b1c1c60245062cbb075c6dc72a44a4f543a6813bff2
> > >> *apache-calcite-avatica-1.20.0-src.tar.gz
> > >>
> > >> A staged Maven repository is available for review at:
> > >>
> > >>
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1122/org/apache/calcite/
> > >>
> > >> Release artifacts are signed with the following key:
> > >> https://people.apache.org/keys/committer/jhyde.asc
> > >> https://www.apache.org/dist/calcite/KEYS
> > >>
> > >> To create the jars and test Apache Calcite Avatica: "gradle build
> > >> -Prelease -PskipSign".
> > >>
> > >> If you do not have a Java/Gradle environment available, you can run
> the
> > >> tests
> > >> using docker. To do so, install docker and docker-compose, then run
> > >> "docker-compose run test" from the root of the directory.
> > >>
> > >> Please vote on releasing this package as Apache Calcite Avatica
> 1.20.0.
> > >>
> > >> The vote is open for the next 18 hours and passes if a majority of at
> > >> least three +1 PMC votes are cast. (The voting period is shorter than
> > >> usual.)
> > >>
> > >> [ ] +1 Release this package as Apache Calcite Avatica 1.20.0
> > >> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > >> [ ] -1 Do not release this package because...
> > >>
> > >>
> > >> Here is my vote:
> > >>
> > >> +1 (binding)
> > >>
> > >
> >
>
