Thanks for spotting that, Stamatis.
My vote is -1 (binding).
I can also confirm that the test fails using a Gradle 7.4.1 / openjdk
17.0.2 2022-01-18 container.
In my case, "gradle check" passes, but running the test by itself using
"gradle cleanTest :core:test --tests
SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency" fails.
Francis
On 15/03/2022 2:12 am, Ruben Q L wrote:
Well spotted Stamatis!
I had not seen this issue in my local build (Windows + jdk1.8.0_212), but I
confirm that, under my environment, the test that you mention also fails
systematically when it is launched individually (I have never seen it
failing within the context of a build).
Therefore I'd lean towards changing my vote into -1 until this issue gets
investigated (and hopefully fixed).
Best regards,
Ruben
On Mon, Mar 14, 2022 at 2:18 PM Stamatis Zampetakis <zabe...@gmail.com>
wrote:
Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, gradle-6.8.3
* Checked signatures and checksums OK
* Went over release note OK
* Built from git tag and run tests (./gradlew clean build) OK
* Built from source artifacts and run tests KO
* Checked diff between repo and source (diff -qr git source) OK
I encountered test failures while building source artifacts which are
reproducible [1]. It seems to come from CALCITE-4872 [2] pointing out a
problem with the new feature when canonization is used in the type factory.
My vote is 0 binding, due to the CALCITE-5040 [1].
Best,
Stamatis
[1] https://issues.apache.org/jira/browse/CALCITE-5040
[2] https://issues.apache.org/jira/browse/CALCITE-4872
On Mon, Mar 14, 2022 at 1:39 PM Enrico Olivelli <eolive...@gmail.com>
wrote:
+1 non binding
HerdDB works like a charm without any changes
https://github.com/diennea/herddb/pull/782
Thanks for running the release
Enrico
Il Lun 14 Mar 2022, 12:02 Fan Liya <liya.fa...@gmail.com> ha scritto:
Hi Ruben,
Thanks a lot for your vote.
Hi all,
Since part of the voting period is during the weekend, let's extend the
voting period to at least 96 hours.
Best,
Liya Fan
Ruben Q L <rube...@gmail.com> 于2022年3月14日周一 18:00写道：
Thanks Liya Fan for being the release manager.
My vote is: +1 (binding)
- Checksum and signature: ok
- Gradle test: ok
- Calcite-based application test suite: ok
Best,
Ruben
On Fri, Mar 11, 2022 at 1:54 PM Fan Liya <liya...@apache.org> wrote:
Hi all,
I have created a build for Apache Calcite 1.30.0, release
candidate 2.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.30.0-rc2/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=170035fd97df1afdd0c0a499f63e0ca1606f7837
Its hash is 170035fd97df1afdd0c0a499f63e0ca1606f7837
Tag:
https://github.com/apache/calcite/tree/calcite-1.30.0-rc2
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc2
(revision 52982)
The hashes of the artifacts are as follows:
988c165bacb3ac20f9046fc80ebcd28eca66504ed3bdd3269ac2625ff59a80b06e3d7de12150ed9fe1e40def8b1a8290a87e280b7a7f0589a5b740fc79e273dd
*apache-calcite-1.30.0-src.tar.gz
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1152/org/apache/calcite/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/COMMITTER_ID.asc
https://www.apache.org/dist/calcite/KEYS
To create the jars and test Apache Calcite: "gradle build"
(requires an appropriate Gradle/JDK installation)
Please vote on releasing this package as Apache Calcite 1.30.0.
The vote is open for the next 72 hours and passes if a majority of
at
least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.30.0
[ ] 0 I don't feel strongly about it, but I'm okay with the
release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (non-binding)
Best,
Liya Fan
