Hey Julian! I followed your suggestions related to the dialect/plugin we want to contribute to Calcite for Firebolt. Some of the issues that we faced so far:
1. Tests are failing in the RelToSqlConverterTest.java file for Firebolt reason being the fact the actual parsed query does not contain the 'Identifier Quote String'. For Firebolt, we've chosen '\"' as the 'Identifier Quote String'. Have followed the approach that other dialects have used and therefore have added support for this in the dialect file as well as in SqlDialect.java and SqlDialectFactoryImpl.java. Have even implemented the method 'withFirebolt()' in the test file. Please guide what else needs to be done for this to be fixed and our test cases to be passed. 2. After adding 'FIREBOLT' to "TEST_DB' in CalciteSystemProperty.java and running the command: ‘./gradlew -Dcalcite.test.db=FIREBOLT test’, Calcite throws an error that it could not find the enum for 'FIREBOLT' in CalciteAssert.java file. Even after adding the enum either with Firebolt's connection string or using one of the given ones, say POSTGRESQL, it couldn't locate the driver in both cases. Need your suggestion to tackle this one. Thanks & Regards, Raghav Sharma | SDE 1 | Data Engineering M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com <https://www.sigmoid.com/> On Tue, Mar 29, 2022 at 1:50 AM Raghav Sharma <ragh...@sigmoidanalytics.com> wrote: > Thank you for the clarification Julian. I will send a mail to > dev-subscr...@calcite.apache.org for subscribing. > > > > On Tue, 29 Mar 2022 at 1:45 AM Julian Hyde <jh...@apache.org> wrote: > >> You did receive a response[1]. But you didn't receive it because you >> are not subscribed to this list. Please subscribe[2]. >> >> Julian >> >> [1] https://lists.apache.org/thread/39obrhwpd95bvhc9sb2n4z6zrrwbc21x >> >> [2] https://calcite.apache.org/community/#mailing-lists >> >> On Mon, Mar 28, 2022 at 1:11 PM Raghav Sharma >> <ragh...@sigmoidanalytics.com> wrote: >> > >> > Gentle reminder! >> > We are expecting a response so that we can move ahead with this >> potential >> > contribution. >> > >> > >> > Thanks & Regards, >> > Raghav Sharma | SDE 1 | Data Engineering >> > M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com >> > <https://www.sigmoid.com/> >> > >> > >> > On Thu, Mar 24, 2022 at 3:47 PM Raghav Sharma < >> ragh...@sigmoidanalytics.com> >> > wrote: >> > >> > > Greetings from Sigmoid and Firebolt! >> > > >> > > >> > > This mail is in reference towards contributing a custom sql dialect to >> > > Calcite. >> > > >> > > >> > > PFB some queries that we have regarding testing the dialect and >> further >> > > for contributing: >> > > >> > > >> > > 1. We have developed a SQL dialect for Firebolt. Need to test it >> against >> > > the database using calcite. How can we do so? Is this something that >> can be >> > > pulled off using the JDBC driver(if so, how?) or is there another way? >> > > >> > > >> > > 2. There are some test files that contain tests for specific dialects. >> > > Before contributing, should we alter those for Firebolt(if required) >> or is >> > > it something that will be taken care of by the Calcite team? >> > > >> > > >> > > 3. Is opening a JIRA case mandatory? Can we raise a PR directly to add >> > > Firebolt to the master branch of Calcite? Please guide us if there’s >> an >> > > alternate option. >> > > >> > > >> > > We are willing to connect over a call as well if that works for you. >> > > >> > > >> > > >> > > Thanks & Regards, >> > > Raghav Sharma | SDE 1 | Data Engineering >> > > M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com >> > > <https://www.sigmoid.com/> >> > > >> > -- >> > Thanks & Regards, >> > Raghav Sharma | SDE 1 | Data Engineering >> > M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com >> > <https://www.sigmoid.com/> >> > >> > -- >> > >> > >> > -- > Thanks & Regards, > Raghav Sharma | SDE 1 | Data Engineering > M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com > <https://www.sigmoid.com/> > --
