Ubuntu 20.04.4 LTS, jdk1.8.0_251, Gradle wrapper, Gradle 7.4.2 * Checked signatures and checksums OK * Went over release note OK * Checked diff between repo and sources (differences appear normal) OK * Built from git tag and run tests (./gradlew clean build) OK * Built from sources and run tests (gradle clean build) OK * Built and run Calcite (at 2e446f2a8a63aeff2513dcb1528664a4335956f2) (./gradlew clean build) using the staged Maven repository OK
+1 (binding) Best, Stamatis On Fri, May 6, 2022 at 10:31 PM Julian Hyde <jh...@apache.org> wrote: > +1 (binding) > > Downloaded, checked hashes, LICENSE, NOTICE, README, README.md, > compiled and ran tests on Gradle 7.4.2 OpenJDK 18 Ubuntu Linux x64. > > There are deprecation warnings when building under OpenJDK 18. We must > fix these before the next release, and make sure that the build fails > if there are deprecation warnings. I have logged > https://issues.apache.org/jira/browse/CALCITE-5136. > > PMC members, when you vote, please describe the steps that you took to > verify the release. > > Julian > > On Thu, May 5, 2022 at 6:12 PM Benchao Li <libenc...@apache.org> wrote: > > > > +1 from my side. > > > > Francis Chuang <francischu...@apache.org> 于2022年5月6日周五 06:14写道： > > > > > Thanks for catching that! I don't think it's a blocker, I'll just > update > > > that after the release. > > > > > > On 5/05/2022 10:38 pm, Benchao Li wrote: > > > > Thanks Francis, > > > > > > > > RC0 generally looks great. > > > > There is one place in docker_images.md[1] which should also be > updated to > > > > 1.21.0, > > > > I don't know whether this should be a blocker. > > > > > > > > [1] > > > > > > > > https://github.com/apache/calcite-avatica/commit/08832629f2b3b85a53dc38fb8d9711328868286a#diff-b692f7ab6240504b936728e7fc4dbbca4f344b930ff4c0a24344e5b11aabf963L73 > > > > > > > > xiong duan <nobigo...@gmail.com> 于2022年5月5日周四 19:51写道： > > > > > > > >> LGTM. +1 > > > >> > > > >> Francis Chuang <francischu...@apache.org> 于2022年5月5日周四 07:32写道： > > > >> > > > >>> Hi all, > > > >>> > > > >>> I have created a build for Apache Calcite Avatica 1.21.0, release > > > >>> candidate 0. > > > >>> > > > >>> Thanks to everyone who has contributed to this release. > > > >>> > > > >>> You can read the release notes here: > > > >>> > > > >>> > > > >> > > > > https://github.com/apache/calcite-avatica/blob/avatica-1.21.0-rc0/site/_docs/history.md > > > >>> > > > >>> The commit to be voted upon: > > > >>> > > > >>> > > > >> > > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=08832629f2b3b85a53dc38fb8d9711328868286a > > > >>> > > > >>> Its hash is 08832629f2b3b85a53dc38fb8d9711328868286a > > > >>> > > > >>> Tag: > > > >>> > > > >>> > > > >> > > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.21.0-rc0 > > > >>> > > > >>> The artifacts to be voted on are located here: > > > >>> > > > >>> > > > >> > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.21.0-rc0 > > > >>> (revision 54264) > > > >>> > > > >>> The hashes of the artifacts are as follows: > > > >>> > > > >>> > > > >> > > > > 74fb94fda0833aaaea2c67d7b497492389e6bbefa2d332bc1d81345d384e3c75a29539c8279ed81bdec44da5c03375ba6dc43a62585a734d0c8f0f15f6d2b9a5 > > > >>> *apache-calcite-avatica-1.21.0-src.tar.gz > > > >>> > > > >>> A staged Maven repository is available for review at: > > > >>> > > > >>> > > > >> > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1154/org/apache/calcite/ > > > >>> > > > >>> Release artifacts are signed with the following key: > > > >>> https://people.apache.org/keys/committer/francischuang.asc > > > >>> https://www.apache.org/dist/calcite/KEYS > > > >>> > > > >>> To create the jars and test Apache Calcite Avatica: "gradle build > > > >>> -Prelease -PskipSign". > > > >>> > > > >>> If you do not have a Java/Gradle environment available, you can > run the > > > >>> tests using docker. To do so, install docker and docker-compose, > then > > > >>> run "docker-compose run test" from the root of the directory. > > > >>> > > > >>> Please vote on releasing this package as Apache Calcite Avatica > 1.21.0. > > > >>> > > > >>> The vote is open for the next 72 hours and passes if a majority of > at > > > >>> least three +1 PMC votes are cast. > > > >>> > > > >>> [ ] +1 Release this package as Apache Calcite Avatica 1.21.0 > > > >>> [ ] 0 I don't feel strongly about it, but I'm okay with the > release > > > >>> [ ] -1 Do not release this package because... > > > >>> > > > >>> > > > >>> Here is my vote: > > > >>> > > > >>> +1 (binding) > > > >>> > > > >>> Francis > > > >>> > > > >> > > > > > > > > > > > > > > > > > -- > > > > Best, > > Benchao Li >
