Git blame reveals that that line of code was added when fixing https://issues.apache.org/jira/browse/CALCITE-1290 <https://issues.apache.org/jira/browse/CALCITE-1290>. https://github.com/apache/calcite/commit/77315c06 <https://github.com/apache/calcite/commit/77315c06>.
I see no reason why toDnf shouldn’t have the same parameter. See if you can make the code similar. Julian > On Aug 12, 2022, at 12:58 PM, Yingyu Wang <yingy...@gmail.com> wrote: > > Does anyone know why RexUtil.toCnf() has a version of the method that takes > a limit arg: toCnf(RexBuilder rexBuilder, int maxCnfNodeCount, RexNode rex), > but there is no such version for RexUtil.toDnf()? > Is there any special reason for this? > Can we add a similar version for RexUtil.toDnf() then?
