Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 * Checked signatures and checksums OK * Went over release note OK * Checked README, LICENSE, NOTICE, and licenses directory (in source distribution) OK * Checked diff between git repo and release sources (diff -qr calcite-git calcite-src) OK * Built from git tag and run tests (./gradlew clean build) OK * Built from source artifacts and run tests (gradlew clean build) OK * Checked (LICENSE, NOTICE, checksums, signatures) calcite-core jar artifacts in the staged maven repository OK
The README mentions "or binary distribution of Apache Calcite" but I don't think we have one; probably we should remove the respective bits. The LICENSE file contains 6 MIT licensed dependencies but we are not bundling those dependencies in the release distribution [1] so I don't think we need to mention them; same goes for the licenses under the respective directory. Will open a separate thread to discuss this further. +1 (binding) Best, Stamatis [1] https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled On Mon, Jul 17, 2023 at 9:24 PM xiong duan <nobigo...@gmail.com> wrote: > > Hi all, > > > I have created a build for Apache Calcite 1.35.0, release > > candidate 2. > > > Thanks to everyone who has contributed to this release. > > > You can read the release notes here: > > https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md > > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=2f5635f13a4eb4b89c119fabf25b1d31e0018426 > > > Its hash is 2f5635f13a4eb4b89c119fabf25b1d31e0018426 > > > Tag: > > https://github.com/apache/calcite/tree/calcite-1.35.0-rc2 > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc2 > > (revision 63046) > > > The hashes of the artifacts are as follows: > > b5d837e3725554254bdad0e4f4a63134193a1e3f44bb9b862d9eeeb7f9a5e9bae01985e2f1857874928dc4dbf1f4ca3ae4debacc096470081c249eba699dc74e > > *apache-calcite-1.35.0-src.tar.gz > > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1213/org/apache/calcite/ > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/xiong.asc > > https://www.apache.org/dist/calcite/KEYS > > > To create the jars and test Apache Calcite: "gradle build" > > (requires an appropriate Gradle/JDK installation) > > > Please vote on releasing this package as Apache Calcite 1.35.0. > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > [ ] +1 Release this package as Apache Calcite 1.35.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > Here is my vote: > > > +1 (binding)
