+1 Downloaded; checked signatures; checked LICENSE, NOTICE; built and ran tests on Linux using Gradle 7.4.2 and OpenJDK 18.0.2; ran rat.
Notes: * Please add your signature to KEYS. I had to import from xiong.asc manually. * The parser generator reports a choice conflict on the "TRUNCATE" keyword; I presume this is a regression introduced by CALCITE-5688. Not a show-stopper. but it needs to be fixed. Julian On Sun, Jul 23, 2023 at 7:37 AM Benchao Li <[email protected]> wrote: > > +1 (binding) > > - checked signature and checksum (OK) > - diffed source with tag (OK) > - build from source (OK, but with an unstable test, I've logged > https://issues.apache.org/jira/browse/CALCITE-5868) > - checked files in Nexus staging (OK) > - checked copyright year in NOTICE (OK) > > Francis Chuang <[email protected]> 于2023年7月23日周日 15:02写道： > > > My vote is: +1 (binding) > > > > - Verified GPG signature - OK > > - Verified SHA512 - OK > > - Diffed source release and git repository - OK > > - Checked release notes on tag > > ( > > https://github.com/apache/calcite/blob/calcite-1.35.0-rc3/site/_docs/history.md) > > > > - OK > > - Checked year and versions in NOTICE, README and HOWTO - OK > > - Ran tests (gradle check) - OK > > - Spot checked Nexus artifacts - OK > > > > Environment: > > Eclipse-temurin:19-jammy docker container in WSL2 (Ubuntu 22.04.2) on > > Windows 11 22h2 > > > > $ docker version > > Client: Docker Engine - Community > > Cloud integration: v1.0.35 > > Version: 24.0.2 > > API version: 1.43 > > Go version: go1.20.4 > > Git commit: cb74dfc > > Built: Thu May 25 21:52:17 2023 > > OS/Arch: linux/amd64 > > Context: default > > > > Server: Docker Desktop > > Engine: > > Version: 24.0.2 > > API version: 1.43 (minimum version 1.12) > > Go version: go1.20.4 > > Git commit: 659604f > > Built: Thu May 25 21:52:17 2023 > > OS/Arch: linux/amd64 > > Experimental: false > > containerd: > > Version: 1.6.21 > > GitCommit: 3dce8eb055cbb6872793272b4f20ed16117344f8 > > runc: > > Version: 1.1.7 > > GitCommit: v1.1.7-0-g860f061 > > docker-init: > > Version: 0.19.0 > > GitCommit: de40ad0 > > > > $ gradle -v > > > > ------------------------------------------------------------ > > Gradle 7.6.1 > > ------------------------------------------------------------ > > > > Build time: 2023-02-24 13:54:42 UTC > > Revision: 3905fe8ac072bbd925c70ddbddddf4463341f4b4 > > > > Kotlin: 1.7.10 > > Groovy: 3.0.13 > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 > > JVM: 19.0.2 (Eclipse Adoptium 19.0.2+7) > > OS: Linux 5.15.90.1-microsoft-standard-WSL2 amd64 > > > > $ java --version > > openjdk 19.0.2 2023-01-17 > > OpenJDK Runtime Environment Temurin-19.0.2+7 (build 19.0.2+7) > > OpenJDK 64-Bit Server VM Temurin-19.0.2+7 (build 19.0.2+7, mixed mode, > > sharing) > > > > Francis > > > > On 22/07/2023 9:40 am, Xiong Duan wrote: > > > Hi all, > > > > > > > > > I have created a build for Apache Calcite 1.35.0, release > > > > > > candidate 3. > > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > > You can read the release notes here: > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.35.0-rc3/site/_docs/history.md > > > > > > > > > The commit to be voted upon: > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=75750b78b5ac692caa654f506fc1515d4d3991d6 > > > > > > > > > Its hash is 75750b78b5ac692caa654f506fc1515d4d3991d6 > > > > > > > > > Tag: > > > > > > https://github.com/apache/calcite/tree/calcite-1.35.0-rc3 > > > > > > > > > The artifacts to be voted on are located here: > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc3 > > > > > > (revision 63131) > > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > a19e0e73dfaa4d54d4d27db24c1b5674979e5461ed4c0bd1408aaec72ff82e832b3e4dee13c9d6552d3b5a9db86c1f11b9a960521e76dd65fc661565e160f63e > > > > > > *apache-calcite-1.35.0-src.tar.gz > > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1216/org/apache/calcite/ > > > > > > > > > Release artifacts are signed with the following key: > > > > > > https://people.apache.org/keys/committer/xiong.asc > > > > > > https://www.apache.org/dist/calcite/KEYS > > > > > > > > > To create the jars and test Apache Calcite: "gradle build" > > > > > > (requires an appropriate Gradle/JDK installation) > > > > > > > > > Please vote on releasing this package as Apache Calcite 1.35.0. > > > > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > least > > > three +1 PMC votes are cast. > > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.35.0 > > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > > > [ ] -1 Do not release this package because... > > > > > > > > > Here is my vote: > > > > > > > > > +1 (binding) > > > > > > > > > Best, > > > Xiong Duan > > > > > > > > -- > > Best, > Benchao Li
