I'm reviewing it, good work Ran! Ran Tao <chucheng...@gmail.com> 于2023年8月21日周一 23:48写道:
> calcite SqlParserTest#keywords test cases failed and it can't be detected > at gradle build process(not covered by build pipeline). It will cause the > gap of keywords to become larger and even cause wrong usage. > > This PR https://github.com/apache/calcite/pull/3366 fix it and covered it > by build pipeline. > It contains 2 related commits CALCITE-5909[1] and CALCITE-5920[2]. > > If someone have time, please help to review it, thanks. > > Jira: > [1] https://issues.apache.org/jira/browse/CALCITE-5909 > [2] https://issues.apache.org/jira/browse/CALCITE-5920 > > > Best Regards, > Ran Tao > -- Best, Benchao Li