Thank you for opening this PR, I left a couple of comments. Best, LakeShen
Runkang He <hrun...@gmail.com> 于2023年9月20日周三 08:29写道： > Hi community, I have submitted two PRs with CALCITE-5825 and CALCITE-5826 > to add some useful string functions. > > In CALCITE-5825, I have added the URL_ENCODE and URL_DECODE function, which > is enabled in Spark library. > In CALCITE-5826, I have added the FIND_IN_SET function, which is enabled in > Hive and Spark library. > > If someone has time, please help me to review these two PRs, I would > appreciate it very much. > > 1.CALCITE-5825: > Jira: https://issues.apache.org/jira/browse/CALCITE-5825 > PR: https://github.com/apache/calcite/pull/3318 > 2.CALCITE-5826: > Jira: https://issues.apache.org/jira/browse/CALCITE-5826 > PR: https://github.com/apache/calcite/pull/3317 > > Best, > Runkang He >
