Thanks Benchao for preparing this release.

- Release notes: ok
- Checksum: ok
- Signature: ok
- Diff source release and git repository: ok
- Build + tests: ok
- Calcite-based application test suite: ok

+1 (binding)

Best,
Ruben


On Tue, Nov 7, 2023 at 9:32 PM Francis Chuang <francischu...@apache.org>
wrote:

> Thanks for being RM for this release, Benchao!
>
> My vote is: +1 (binding)
>
> - Verified GPG signature - OK
> - Verified SHA512 - OK
> - Diffed source release and git repository - OK
> - Checked release notes on tag
> (
> https://github.com/apache/calcite/blob/calcite-1.36.0-rc0/site/_docs/history.md)
>
> - OK
> - Checked year and versions in NOTICE, README and HOWTO - OK
> - Ran tests (gradle check) - OK
> - Spot checked Nexus artifacts - OK
>
> Environment:
> Eclipse-temurin:19-jammy docker container in WSL2 (Ubuntu 22.04.3) on
> Windows 11 22h2
>
> $ docker version
> Client: Docker Engine - Community
>   Cloud integration: v1.0.35+desktop.5
>   Version:           24.0.6
>   API version:       1.43
>   Go version:        go1.20.7
>   Git commit:        ed223bc
>   Built:             Mon Sep  4 12:32:16 2023
>   OS/Arch:           linux/amd64
>   Context:           default
>
> Server: Docker Desktop
>   Engine:
>    Version:          24.0.6
>    API version:      1.43 (minimum version 1.12)
>    Go version:       go1.20.7
>    Git commit:       1a79695
>    Built:            Mon Sep  4 12:32:16 2023
>    OS/Arch:          linux/amd64
>    Experimental:     false
>   containerd:
>    Version:          1.6.22
>    GitCommit:        8165feabfdfe38c65b599c4993d227328c231fca
>   runc:
>    Version:          1.1.8
>    GitCommit:        v1.1.8-0-g82f18fe
>   docker-init:
>    Version:          0.19.0
>    GitCommit:        de40ad0
>
> $ gradle -v
>
> ------------------------------------------------------------
> Gradle 7.6.1
> ------------------------------------------------------------
>
> Build time:   2023-02-24 13:54:42 UTC
> Revision:     3905fe8ac072bbd925c70ddbddddf4463341f4b4
>
> Kotlin:       1.7.10
> Groovy:       3.0.13
> Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> JVM:          19.0.2 (Eclipse Adoptium 19.0.2+7)
> OS:           Linux 5.15.90.1-microsoft-standard-WSL2 amd64
>
> $ java --version
> openjdk 19.0.2 2023-01-17
> OpenJDK Runtime Environment Temurin-19.0.2+7 (build 19.0.2+7)
> OpenJDK 64-Bit Server VM Temurin-19.0.2+7 (build 19.0.2+7, mixed mode,
> sharing)
>
> Francis
>
> On 8/11/2023 7:55 am, Julian Hyde wrote:
> > Oops, Ubuntu 23.10. Obviously.
> >
> > On Tue, Nov 7, 2023 at 12:02 PM Julian Hyde <jh...@apache.org> wrote:
> >>
> >> +1 (binding)
> >>
> >> Downloaded; checked signatures & hashes; checked LICENSE, NOTICE,
> >> README, README.md, howto.md, history.md; ran RAT; compared to git tag.
> >> Built and ran tests using Gradle 7.4.2, OpenJDK 19.0.2, Ubuntu 24.10.
> >>
> >> Thanks Benchao!
> >>
> >> Julian
> >>
> >> On Tue, Nov 7, 2023 at 7:41 AM LakeShen <shenleifight...@gmail.com>
> wrote:
> >>>
> >>> Thanks to Benchao’s contributions
> >>>
> >>> +1(binding)
> >>>
> >>> Best,
> >>> LakeShen
> >>>
> >>> Benchao Li <libenc...@apache.org> 于2023年11月7日周二 13:20写道:
> >>>
> >>>> Hi all,
> >>>>
> >>>> I have created a build for Apache Calcite 1.36.0, release
> >>>> candidate 0.
> >>>>
> >>>> Thanks to everyone who has contributed to this release.
> >>>>
> >>>> You can read the release notes here:
> >>>>
> >>>>
> https://github.com/apache/calcite/blob/calcite-1.36.0-rc0/site/_docs/history.md
> >>>>
> >>>> The commit to be voted upon:
> >>>>
> >>>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=0be8eaebcf27afae9ecda8ab79db63c214426561
> >>>>
> >>>> Its hash is 0be8eaebcf27afae9ecda8ab79db63c214426561
> >>>>
> >>>> Tag:
> >>>> https://github.com/apache/calcite/tree/calcite-1.36.0-rc0
> >>>>
> >>>> The artifacts to be voted on are located here:
> >>>>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.36.0-rc0
> >>>> (revision 65079)
> >>>>
> >>>> The hashes of the artifacts are as follows:
> >>>>
> >>>>
> 3bf003a87f76f2fa85b6af9b5243cddf67c767cb5caa828532784bd380e0d929da097677a453dc8d6a0d31f8cf97085031cf66b15a390571065b666095db3b80
> >>>> *apache-calcite-1.36.0-src.tar.gz
> >>>>
> >>>> A staged Maven repository is available for review at:
> >>>>
> >>>>
> https://repository.apache.org/content/repositories/orgapachecalcite-1219/org/apache/calcite/
> >>>>
> >>>> Release artifacts are signed with the following key:
> >>>> https://people.apache.org/keys/committer/libenchao.asc
> >>>> https://www.apache.org/dist/calcite/KEYS
> >>>>
> >>>> To create the jars and test Apache Calcite: "gradle build"
> >>>> (requires an appropriate Gradle/JDK installation)
> >>>>
> >>>> Please vote on releasing this package as Apache Calcite 1.36.0.
> >>>>
> >>>> The vote is open for the next 72 hours and passes if a majority of at
> >>>> least three +1 PMC votes are cast.
> >>>>
> >>>> [ ] +1 Release this package as Apache Calcite 1.36.0
> >>>> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >>>> [ ] -1 Do not release this package because...
> >>>>
> >>>> Here is my vote:
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>> --
> >>>>
> >>>> Best,
> >>>> Benchao Li
> >>>>
>

Reply via email to