Thanks Francis for pointing it out, '-Pcheckstyle.version=9.3' works fine. My vote is +1 (binding).
Francis Chuang <[email protected]> 于2023年11月27日周一 13:12写道： > > I think we need to force an older version of Checkstyle when using JDK8. > See: > https://issues.apache.org/jira/browse/CALCITE-5329?focusedCommentId=17628456&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17628456 > > On 27/11/2023 3:55 pm, Benchao Li wrote: > > - Verified checksum and signature (OK) > > - Gone through release note (OK) > > - Diffed source release with git repo (OK) > > - Checked files in Nexus (OK) > > - Compile and test sources with JDK8 (NOT SURE) > > > > While compiling the sources with JDK8, I've encountered: > > $java -version > > java version "1.8.0_371" > > Java(TM) SE Runtime Environment (build 1.8.0_371-b11) > > Java HotSpot(TM) 64-Bit Server VM (build 25.371-b11, mixed mode) > > $./gradlew build > > FAILURE: Build completed with 5 failures. > > > > 1: Task failed with an exception. > > ----------- > > * What went wrong: > > Execution failed for task ':metrics:checkstyleMain'. > >> A failure occurred while executing > >> org.gradle.api.plugins.quality.internal.CheckstyleAction > > > com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask has been > > compiled by a more recent version of the Java Runtime (class file > > version 55.0), this version of the Java Runtime only recognizes class > > file versions up to 52.0 > > > > Francis Chuang <[email protected]> 于2023年11月27日周一 07:54写道： > >> > >> Hi all, > >> > >> I have created a build for Apache Calcite Avatica 1.24.0, release > >> candidate 0. > >> > >> Thanks to everyone who has contributed to this release. > >> > >> You can read the release notes here: > >> https://github.com/apache/calcite-avatica/blob/avatica-1.24.0-rc0/site/_docs/history.md > >> > >> The commit to be voted upon: > >> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=01a7a9e956b3fe8ad999a5b82e5d9924434cb309 > >> > >> Its hash is 01a7a9e956b3fe8ad999a5b82e5d9924434cb309 > >> > >> Tag: > >> https://github.com/apache/calcite-avatica/tree/avatica-1.24.0-rc0 > >> > >> The artifacts to be voted on are located here: > >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.24.0-rc0 > >> > >> The hashes of the artifacts are as follows: > >> 927707b23a1338105fbb9d0a9a1836baf3e95e20002407b483b8f663927c5d41d844b2a09ec2cd1e580ae2e29d930ad32ee308d0d04550c35d8daefa7ad777c3 > >> *apache-calcite-avatica-1.24.0-src.tar.gz > >> > >> A staged Maven repository is available for review at: > >> https://repository.apache.org/content/repositories/orgapachecalcite-1221/org/apache/calcite/ > >> > >> Release artifacts are signed with the following key: > >> https://people.apache.org/keys/committer/francischuang.asc > >> https://www.apache.org/dist/calcite/KEYS > >> > >> To create the jars and test Apache Calcite Avatica: "gradle build > >> -Prelease -PskipSign". > >> > >> If you do not have a Java/Gradle environment available, you can run the > >> tests using docker. To do so, install docker and docker-compose, then > >> run "docker-compose run test" from the root of the directory. > >> > >> Please vote on releasing this package as Apache Calcite Avatica 1.24.0. > >> > >> The vote is open for the next 72 hours and passes if a majority of at > >> least three +1 PMC votes are cast. > >> > >> [ ] +1 Release this package as Apache Calcite Avatica 1.24.0 > >> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >> [ ] -1 Do not release this package because... > >> > >> > >> Here is my vote: > >> > >> +1 (binding) > >> > >> Francis > > > > > > -- Best, Benchao Li
