Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 8.1.1
* Checked signatures and checksums OK
* Checked diff between repo and artifacts OK
* Went over release note OK (Minor comments at the end)
* Checked README, NOTICE, LICENSE OK ([1, 2, 3, 4] should be ported to Avatica)
* All source files have ASF headers OK (raised [5] to investigate if
additional action are needed for some files without header)
* No unexpected binary files OK (find . -type f -exec file {} \; |
grep -v text)
* Checked LICENSE, NOTICE, signature, and checksum for
avatica-core-1.24.0.jar in nexus [8] OK
* Built from git tag and run tests (./gradlew build) OK
* Built from source artifacts and run tests (gradle build) OK
In the release notes, I think we should highlight that CALCITE-5678
[6] is a breaking change. We probably also have to update the testing
and compatibility section to reflect what we actually test against.
Sergey pointed out correctly [7] that the description is a bit stale
in Calcite and the same holds for Avatica.
+1 (binding)
Best,
Stamatis
[1]
https://github.com/apache/calcite/commit/d802314e69f1eb975558ad3fd6013dc05ddaef7a
[2] https://issues.apache.org/jira/browse/CALCITE-6096
[3] https://issues.apache.org/jira/browse/CALCITE-6097
[4] https://issues.apache.org/jira/browse/CALCITE-6099
[5] https://issues.apache.org/jira/browse/CALCITE-6148
[6] https://issues.apache.org/jira/browse/CALCITE-5678
[7]
https://issues.apache.org/jira/browse/CALCITE-6137?focusedCommentId=17790295&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17790295
[8]
https://repository.apache.org/content/repositories/orgapachecalcite-1222/org/apache/calcite/avatica/avatica-core/1.24.0/avatica-core-1.24.0.jar
On Thu, Nov 30, 2023 at 6:01 AM Benchao Li <libenc...@apache.org> wrote:
>
> +1(binding)
>
> - Verified checksum and signature (OK)
> - Gone through release note (OK)
> - Diffed source release with git repo (OK)
> - Checked files in Nexus (OK)
> - Compile and test sources with JDK8 (OK)
>
> Noted that the tag link
> (https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.24.0-rc1)
> is directed to a non existed page, it should be
> https://github.com/apache/calcite-avatica/tree/avatica-1.24.0-rc1
>
> Istvan Toth <st...@cloudera.com.invalid> 于2023年11月29日周三 15:26写道：
>
> >
> > +1 (non binding)
> >
> > Thanks for making the JDK8 build painless.
> >
> > On Wed, Nov 29, 2023 at 1:21 AM Francis Chuang <francischu...@apache.org>
> > wrote:
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite Avatica 1.24.0, release
> > > candidate 1.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> > > https://github.com/apache/calcite-avatica/blob/avatica-1.24.0-rc1/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=4c0999ba154915eee201bd7a037e223e9368a97d
> > >
> > > Its hash is 4c0999ba154915eee201bd7a037e223e9368a97d
> > >
> > > Tag:
> > >
> > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.24.0-rc1
> > >
> > > The artifacts to be voted on are located here:
> > >
> > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.24.0-rc1
> > > (revision 65633)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > > 41da104d811b3925cbf19452cbe3acac8271bae188efb21f4eed9738dd13b1e353923f63a5ed73aefb05a1d5004211e0d438520b268c9e5d3f3f6c8f98c3be00
> > > *apache-calcite-avatica-1.24.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > > https://repository.apache.org/content/repositories/orgapachecalcite-1222/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/francischuang.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite Avatica: "gradle build
> > > -Prelease -PskipSign".
> > >
> > > If you do not have a Java/Gradle environment available, you can run the
> > > tests using docker. To do so, install docker and docker-compose, then
> > > run "docker-compose run test" from the root of the directory.
> > >
> > > Please vote on releasing this package as Apache Calcite Avatica 1.24.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite Avatica 1.24.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Francis
> > >
> >
> >
> > --
> > *István Tóth* | Sr. Staff Software Engineer
> > *Email*: st...@cloudera.com
> > cloudera.com <https://www.cloudera.com>
> > [image: Cloudera] <https://www.cloudera.com/>
> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
> > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
> > on LinkedIn] <https://www.linkedin.com/company/cloudera>
> > ------------------------------
> > ------------------------------
>
>
>
> --
>
> Best,
> Benchao Li
