Thanks for picking this up. One of my students and myself wrote a lot of the original code. For a while this was blocked on necessary changes to Apache Arrow, but this has since been resolved. I'd love to see this get merged. It would help to rebase into a single commit. I'd also appreciate one more set of eyes before this gets wrapped up. Thanks again Hongyu!
-- Michael Mior mm...@apache.org On Fri, Feb 2, 2024 at 6:40 AM Hongyu Guo <guohongyu...@gmail.com> wrote: > Hi devs, > > Recently I found a [CALCITE-2040] "Create adapter for Apache Arrow"[1] that > is almost finished in PR#2810[2], but no one continues to push it forward, > so I want to take it. I made some changes to the existing PR, including > - Upgrade arrow to 15.0 > - Prohibit arrow adapter CI on Windows (for arrow system compatibility[3]) > - Add JAVA_OPTIONS for JDK19 CI --add-opens=java.base/java.nio=ALL-UNNAMED > (for arrow java compatibility[4]) > > This is my PR link: https://github.com/apache/calcite/pull/3666 > > I haven't made any feature changes because I'm not familiar enough with > Apache Arrow. I found that Jenkins CI will fail due to the JAVA_OPTIONS, > and I will fix it later. > > Best, > Hongyu > > [1] https://issues.apache.org/jira/browse/CALCITE-2040 > [2] https://github.com/apache/calcite/pull/2810/commits > [3] https://arrow.apache.org/docs/java/install.html#system-compatibility > [4] https://arrow.apache.org/docs/java/install.html#java-compatibility >
