The expected test output changes. But we don't know exactly when calcite moves to the next avatica version, so I shouldn't disable the quidem tests until the last moment... ________________________________ From: Tanner Clary <[email protected]> Sent: Monday, February 26, 2024 6:29:38 PM To: [email protected] <[email protected]> Subject: Re: Simulataneous changes to Avatica and Calcite
How do the tests fail? You could use deprecated methods? You could also block the quidem tests with a TODO for the JIRA (is that hacky?) On Mon, Feb 26, 2024 at 5:58 PM Mihai Budiu <[email protected]> wrote: > Hello, > > I have submitted a fix to Avatica improving the output of times and > timestamps with precision, for this issue: > https://issues.apache.org/jira/browse/CALCITE-6282 (Avatica ignores time > precision when returning TIME results) > > However, fixing this issue makes several Calcite tests fail, including > some Quidem tests. > I can submit a PR on the Calcite side, but the two PRs have to be merged > at the same time. > I have seen conditional code in Java based on the avatica version, but I > don't know what to do about Quidem tests. > Any suggestions on what I should do? > > Thank you, > Mihai >
