I have merged 6282 and 6248 in Avatica. Mihai ________________________________ From: Francis Chuang <francischu...@apache.org> Sent: Monday, March 18, 2024 4:09 AM To: dev@calcite.apache.org <dev@calcite.apache.org> Subject: Re: Pull Request Reviews for Avatica
Going through the open PRs again (thanks to community members who reviewed and merged!), I think these are definitely candidates that can be merged for the 1.25.0 release: - CALCITE-6282 - Avatica ignores time precision when returning TIME results [1] - CALCITE-6248 - Illegal dates are accepted by casts [2] - CALCITE-6137 - Upgrade Gradle from 8.1.1 to 8.5, support jdk21 [3] This one also has some potential as I think there is consensus that's it's almost ready (with some minor changes): - CALCITE-5964 - Add test case checking that connection.getMetaData().getTables() handles responses with different signature shapes. [4] These are probably a stretch as there hasn't been consensus yet, but would be nice to have: - CALCITE-6135 - BEARER authentication support [5] - CALCITE-5534 - Add userAgent JDBC param [6] These 3 are linked together and will probably need a significant amount of work: - CALCITE-5535 - Properly truncate time values [7] - CALCITE-5446 - Add support for TIMESTAMP WITH LOCAL TIME ZONE [8] - CALCITE-5487 - Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE [9] Community members, please take a look at the PRs listed and review and merge if they are ready. Francis [1] https://github.com/apache/calcite-avatica/pull/241 [2] https://github.com/apache/calcite-avatica/pull/238 [3] https://github.com/apache/calcite-avatica/pull/234 [4] https://github.com/apache/calcite-avatica/pull/227 [5] https://github.com/apache/calcite-avatica/pull/232 [6] https://github.com/apache/calcite-avatica/pull/211 [7] https://github.com/apache/calcite-avatica/pull/210 [8] https://github.com/apache/calcite-avatica/pull/209 [9] https://github.com/apache/calcite-avatica/pull/205 On 12/03/2024 8:03 am, Francis Chuang wrote: > Going slightly off-topic: I can be RM for the next Avatica release to > make this happen. > > Francis > > On 12/03/2024 4:38 am, Mihai Budiu wrote: >> I haven't spent too much time trying to fix the CI problem, I was >> planning to spend some time on this, but this email triggered my >> response before I had time to investigate. >> >> I have two PRs outstanding against Avatica which need fixes in both >> sides: >> >> Illegal dates are accepted by casts >> https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6248 >> https://github.com/apache/calcite-avatica/pull/238 >> >> Avatica ignores time precision when returning TIME results >> https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6282 >> https://github.com/apache/calcite-avatica/pull/241 >> >> Mihai >> >> ________________________________ >> From: Julian Hyde <jhyde.apa...@gmail.com> >> Sent: Monday, March 11, 2024 9:49 AM >> To: dev@calcite.apache.org <dev@calcite.apache.org> >> Subject: Re: Pull Request Reviews for Avatica >> >> Mihai, >> >> Can you list the PRs (jira cases) in this category? >> >> I thought I suggested a solution. disable tests in Calcite based on >> the Avatica version number. And make the changes just before an >> Avatica release, and quickly upgrade Calcite, so that any tests you >> need to disable aren’t disabled for long. >> >> I’m sure most of the PRs that Francis refers to will not break >> Calcite, so there’s no reason to defer those. >> >> Julian >> >>> On Mar 11, 2024, at 09:28, Mihai Budiu <mbu...@gmail.com> wrote: >>> >>> Some fixes in avatica require simultaneous fixes in Calcite - >>> sometimes just tests that behave differently. I haven't figured out a >>> good process that makes both CIs happy. >>> >>> Mihai >>> ________________________________ >>> From: Francis Chuang <francischu...@apache.org> >>> Sent: Saturday, March 9, 2024 9:18 PM >>> To: dev@calcite.apache.org <dev@calcite.apache.org> >>> Subject: Pull Request Reviews for Avatica >>> >>> Hey everyone! >>> >>> Looking at the open pull requests for Avatica [1], it seems that there >>> are a few that have been languishing for a while. >>> >>> Some of them seem pretty uncontroversial and simple, but there are some >>> that will require further discussion (whether through the jira issue or >>> here on the list). >>> >>> Can community members please spare some time to review some of the PRs >>> and commit them? >>> >>> Francis >>> >>> [1] https://github.com/apache/calcite-avatica/pulls
