+1 Xiong Duan (PMC)
Thanks Alessandro for preparing the RC, this is what I have checked: - verified gpg signature: OK - verified package checksum: OK - verified gradle build from sources: OK - checked release notes: OK - checked gradlew build: OK Environment: ➜ calcite git:(calcite-1.40.0-rc1) ./gradlew -version ------------------------------------------------------------ Gradle 8.7 ------------------------------------------------------------ Build time: 2024-03-22 15:52:46 UTC Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 Kotlin: 1.9.22 Groovy: 3.0.17 Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 JVM: 21.0.4 (Amazon.com Inc. 21.0.4+7-LTS) OS: Mac OS X 12.7.6 x86_64 ➜ calcite git:(calcite-1.40.0-rc1) java -version openjdk version "21.0.4" 2024-07-16 LTS OpenJDK Runtime Environment Corretto-21.0.4.7.1 (build 21.0.4+7-LTS) OpenJDK 64-Bit Server VM Corretto-21.0.4.7.1 (build 21.0.4+7-LTS, mixed mode, sharing) Francis Chuang <[email protected]> 于2025年5月24日周六 16:37写道: > > Thank you for quickly making rc1 available for voting, Alessandro. > > My vote is: +1 francischuang (PMC) > > - Verified GPG signature - OK > - Verified SHA512 - OK > - Diffed source release and git repository - OK > - Checked release notes on tag > (https://github.com/apache/calcite/blob/calcite-1.40.0-rc1/site/_docs/history.md) > - OK > - Checked year and versions in NOTICE, README and HOWTO - OK > - Ran tests (gradle check) - OK > - Spot checked Nexus artifacts - OK > > Environment: > Eclipse-temurin:23 docker container in WSL2 (Ubuntu 24.04.2) on Windows > 11 24h2 > > $ docker version > Client: > Version: 28.1.1 > API version: 1.49 > Go version: go1.23.8 > Git commit: 4eba377 > Built: Fri Apr 18 09:51:06 2025 > OS/Arch: linux/amd64 > Context: default > > Server: Docker Desktop 4.0.0 () > Engine: > Version: 28.1.1 > API version: 1.49 (minimum version 1.24) > Go version: go1.23.8 > Git commit: 01f442b > Built: Fri Apr 18 09:52:57 2025 > OS/Arch: linux/amd64 > Experimental: false > containerd: > Version: 1.7.27 > GitCommit: 05044ec0a9a75232cad458027ca83437aae3f4da > runc: > Version: 1.2.5 > GitCommit: v1.2.5-0-g59923ef > docker-init: > Version: 0.19.0 > GitCommit: de40ad0 > > $ gradle -v > > ------------------------------------------------------------ > Gradle 8.7 > ------------------------------------------------------------ > > Build time: 2024-03-22 15:52:46 UTC > Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 > > Kotlin: 1.9.22 > Groovy: 3.0.17 > Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 > JVM: 23.0.2 (Eclipse Adoptium 23.0.2+7) > OS: Linux 5.15.167.4-microsoft-standard-WSL2 amd64 > > $ java --version > openjdk 23.0.2 2025-01-21 > OpenJDK Runtime Environment Temurin-23.0.2+7 (build 23.0.2+7) > OpenJDK 64-Bit Server VM Temurin-23.0.2+7 (build 23.0.2+7, mixed mode, > sharing) > > Francis > > On 24/05/2025 5:46 pm, Stamatis Zampetakis wrote: > > Ubuntu 22.04.5 LTS, jdk1.8.0_421, Gradle wrapper, Gradle 8.7 > > > > * Checked signatures and checksums OK > > * Checked diff between repo and artifacts OK > > * Went over release note OK (Minor comments at the end) > > * Checked README, NOTICE, LICENSE OK > > * All source files have ASF headers OK (grep -RiL "Licensed to the > > Apache Software Foundation") > > * No unexpected binary files OK (find . -type f -exec file {} \; | > > grep -v text) > > * Checked LICENSE, NOTICE for calcite-core-1.40.0.jar in nexus OK > > * Built from git tag and run tests (./gradlew build) OK > > * Built from source artifacts and run tests (gradle build) OK > > > > CALCITE-6959 [1] and CALCITE-6961 [2] are breaking changes since they > > add non-default methods in a widely used user facing interface so they > > should be marked as such. > > > > +1 zabetak (PMC member) > > > > Best, > > Stamatis > > > > [1] https://issues.apache.org/jira/browse/CALCITE-6959 > > [2] https://issues.apache.org/jira/browse/CALCITE-6961 > > > > > > > > On Fri, May 23, 2025 at 6:44 PM Alessandro Solimando > > <[email protected]> wrote: > >> > >> Hi all, > >> > >> I have created a build for Apache Calcite 1.40.0, release > >> candidate 1. > >> > >> Thanks to everyone who has contributed to this release. > >> > >> You can read the release notes here: > >> https://github.com/apache/calcite/blob/calcite-1.40.0-rc1/site/_docs/history.md > >> > >> The commit to be voted upon: > >> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e2e77aaf172ce997b92a9e574b5fcf77a6dc297a > >> > >> Its hash is e2e77aaf172ce997b92a9e574b5fcf77a6dc297a > >> > >> Tag: > >> https://github.com/apache/calcite/tree/calcite-1.40.0-rc1 > >> > >> The artifacts to be voted on are located here: > >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.40.0-rc1 > >> (revision 77099) > >> > >> The hashes of the artifacts are as follows: > >> d4a3b80a19ebb62b43b4e1169a6ad16c7874fd5e76c56d656562fcb6aec488a4cc007f433ae78cd29e03c40220914a7ba0985e445f3c966ca3083aafe524f735 > >> *apache-calcite-1.40.0-src.tar.gz > >> > >> A staged Maven repository is available for review at: > >> https://repository.apache.org/content/repositories/orgapachecalcite-1247/org/apache/calcite/ > >> > >> Release artifacts are signed with the following key: > >> https://people.apache.org/keys/committer/asolimando.asc > >> https://www.apache.org/dist/calcite/KEYS > >> > >> To create the jars and test Apache Calcite: "gradle build" > >> (Requires an appropriate Gradle/JDK installation.) > >> > >> Please vote on releasing this package as Apache Calcite 1.40.0. > >> Everyone is welcome to vote. Your vote should contain the line > >> 'code name (role)', where > >> * 'code' is +1, 0 or -1 as below; > >> * 'name' is your ASF id if you have one, else your real name; > >> * 'role' is 'community', 'committer' or 'PMC member'. > >> > >> [ ] +1 Release this package as Apache Calcite 1.40.0 > >> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >> [ ] -1 Do not release this package because... > >> > >> The vote is open for the next ~4.5 days (closing at > >> 2025-05-28T8:00:00Z) and passes if a majority of > >> at least three +1 votes by PMC members are cast. > >> > >> NOTE: LICENSE file differs from that of git, it has been discussed in [1], > >> it's not considered a blocker and CALCITE-7036 [2] has been filed to > >> improve this aspect > >> > >> Here is my vote: > >> > >> +1 asolimando (PMC member) > >> > >> Alessandro (release manager) > >> > >> [1]: https://lists.apache.org/thread/hfxqnm0xc8l5nzdbsm2fon91rw94t3to > >> [2]: https://issues.apache.org/jira/browse/CALCITE-7036 >
