Stamatis Zampetakis created CALCITE-7130:
--------------------------------------------

             Summary: DiffRepository does not enforce any order on XML resources
                 Key: CALCITE-7130
                 URL: https://issues.apache.org/jira/browse/CALCITE-7130
             Project: Calcite
          Issue Type: Bug
          Components: tests
            Reporter: Stamatis Zampetakis


As agreed in CALCITE-4593, the DiffRepository class must ensure that the 
{{TestCase}} resources in the reference/golden XML file are in alphabetical 
order and raise errors if that's not the case. Moreover, the generated 
reference file should always contain the resources sorted based on the name of 
the {{TestCase}}.

At the moment (commit 4fa0d5bbe987c4ae0779ca434fb71e1ae8637b77) none of the 
above happens. The problem can be reproduced easily by manually changing the 
order of the TestCases inside a reference file (e.g., 
[RelOptRulesTest.xml|https://github.com/apache/calcite/blob/4fa0d5bbe987c4ae0779ca434fb71e1ae8637b77/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml])
 and then running the respective test. Instead of failing the test will pass 
without problems.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to