On Tue, Mar 17, 2009 at 10:44 AM, Willem Jiang <willem.ji...@gmail.com> wrote: > +1 for using the Executor to support the managed thread. Hi
I have fixed this now and will commit a fix in short time on trunk. > > Willem > > Claus Ibsen wrote: >> Hi >> >> Another minor note. >> We might wanna make sure the threads we create in Camel is using the >> same API so end users can be 100% in control of thread creation. >> Eg in WebSphere to use its WorkManager API to control threads. >> >> So maybe some ExectutorService is needed as well? Just wondering / >> thinking loud. >> >> >> On Tue, Mar 17, 2009 at 10:24 AM, Claus Ibsen <claus.ib...@gmail.com> wrote: >>> Hi >>> >>> I was working on CAMEL-1462 and I was wondering why the >>> JMXConnectorThread created in >>> DefaultInstrumentationAgent#createJmxConnector is not set as daemon? >>> >>> eg in the code below there should be a: connector.setDaemon(true) >>> >>> >>> // Start the connector server asynchronously (in a separate thread). >>> Thread connectorThread = new Thread() { >>> public void run() { >>> try { >>> cs.start(); >>> } catch (IOException ioe) { >>> LOG.warn("Could not start JMXConnector thread.", ioe); >>> } >>> } >>> }; >>> connectorThread.setName("Camel JMX Connector Thread [" + url + "]"); >>> connectorThread.start(); >>> LOG.info("JMX Connector thread started and listening at: " + url); >>> >>> >>> >>> -- >>> Claus Ibsen >>> Apache Camel Committer >>> >>> Open Source Integration: http://fusesource.com >>> Blog: http://davsclaus.blogspot.com/ >>> >> >> >> > > -- Claus Ibsen Apache Camel Committer Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/