[ 
https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52682#action_52682
 ] 

Claus Ibsen commented on CAMEL-1787:
------------------------------------

Janstey be careful the loading of custom SSLTrustManager is flawed.

It should not use a string to load a class name using Class.forName etc.
What you should do instead is having a SSLTrustManager setter/getter on the 
endpoint.

And then use Spring IoC or the likes to setup the implementation.

So I would like this patch to be fixed by
{code}
ircEndpoint

  private SSLTrustManager sslTrustManager = new DefaultSSLTrustManager();

  // add getter/setter to it
{code}

And remove the trustManagerClass option as its not needed.

Then you can use a custom manager like this
{code}
ircs://<username>:server:6667/#channel?sslTruastManager=#myCustomManager
{code}

And Camel will lookup in the registry for the custom manager by this given id.


> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to 
> SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC 
> server that's SSL enabled to add a test for this but have tested here a bunch 
> against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use 
> [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html]
>  but I've added in another parameter so you can pass ?trustManagerClass and 
> specify a class that implements 
> [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to