I already did the fix , you don't need to commit the code :)

Willem
Charles Moulliard wrote:
I have been informed about this by Claus. I have finished the modifications.
What should I do (commit or not) ?

Charles Moulliard
Senior Enterprise Architect
Apache Camel Committer

*****************************
blog : http://cmoulliard.blogspot.com


On Thu, Jul 16, 2009 at 10:09 AM, Willem Jiang <willem.ji...@gmail.com>wrote:

Hi Charles,

The code that you committed does not work yet.
Don't worry , I just did a quick fix for it :)

Willem


Charles Moulliard wrote:

Sorry for my omission. Code is committed.

Regards,

Charles Moulliard
Senior Enterprise Architect
Apache Camel Committer

*****************************
blog : http://cmoulliard.blogspot.com


On Thu, Jul 16, 2009 at 3:40 AM, Willem Jiang <willem.ji...@gmail.com
wrote:
 Hi Charles
I think you didn't comment the package of
"org.apache.camel.dataformat.bindy.model.simple.oneclassmandatory"
So the test of BindySimpleCsvMandatoryFieldsUnmarshallTest is failed.

Please using "svn st" to double check the code with ? states before you
commit the code :)

Willem

cmoulli...@apache.org wrote:

 Author: cmoulliard
Date: Wed Jul 15 12:09:00 2009
New Revision: 794245

URL: http://svn.apache.org/viewvc?rev=794245&view=rev
Log:
Add a new property in annotation DataField.java to define mandatory
fields, generate exceptions in BindyCsvDataFormat when record is empty
in
case of missing mandatory fields.

Added:
  camel/trunk/components/camel-bindy/src/test/data3/
  camel/trunk/components/camel-bindy/src/test/data3/csv.txt   (with
props)


 
camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvMandatoryFieldsUnmarshallTest.java
 (with props)
Modified:


 
camel/trunk/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java


 
camel/trunk/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java


 
camel/trunk/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/annotation/DataField.java


 
camel/trunk/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/csv/BindyCsvDataFormat.java
  camel/trunk/components/camel-bindy/src/test/data/csv.txt


 
camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindyComplexCsvUnmarshallTest.java


 
camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvSkipFirstLineUnmarshallTest.java


 
camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallDslTest.java


 
camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallTest.java





Reply via email to