Hi Hadrian,
I have digged into the next failure.
CachedOutputStreamTest.testCacheStreamToFileAndNotCloseStream
At the end of the test the temporary file is expected to be deleted. But
honestly I do not understand how this could work.
The test first calls exchange.getUnitOfWork().done(exchange);. This will
try to delete the file but the delete will fail as the stream is still open.
Then it calls ((InputStream)cache).close(); which will close the stream.
The problem is that now the file will not be deleted again.
I have swapped the two commands and the test works but I think this is
wrong as the test seems to explicitly test the fact that close is not
called before done.
Can anyone clarify what this test tries to do?
Btw. I think this test works on unix as the delete on the file will also
work when the file is opened. On windows this does not work.
Greetings
Christian
Hadrian Zbarcea schrieb:
Hi Christian,
Thanks for doing the tests. No, it is not ok, but all the tests are
passing consistently for a few weeks on mac and linux. That code is
not quite platform specific (well, except for the Windows fs). Could
you *please* take a look a bit more and maybe figure out what the
issue is? Is it a fluke, a timing issue, a more serious problem, does
it work from an IDE like Eclipse?
Imho this is not a blocker for this release (yet), but it's good to know.
Many thanks again,
Hadrian
On Aug 19, 2009, at 7:26 AM, Christian Schneider wrote:
I just checked out the head (hope this is still the release 2.0.0
state) and did a full build. I got three test failures in camel-core.
Is this ok?
I built on Windows Vista, JDK 1.6.0_14 and maven 2.2.0.
Greetings
Christian
Failure Details
<icon_warning_sml.gif> testCannotDeleteFile
junit.framework.AssertionFailedError: Should have thrown an exception
org.apache.camel.component.file.strategy.GenericFileDeleteProcessStrategyTest:125
<icon_warning_sml.gif> testCacheStreamToFileAndNotCloseStream
junit.framework.AssertionFailedError: we should have no temp file
expected:<1> but was:<0>
org.apache.camel.converter.stream.CachedOutputStreamTest:117
<icon_warning_sml.gif> testRouteIsCorrectAtRuntime
junit.framework.AssertionFailedError: expected:<4> but was:<1>
org.apache.camel.processor.ChoiceWithEndTest:39
Hadrian Zbarcea schrieb:
The first release candidate of apache-camel-2.0.0 is out with 61 new
features, improvements and bug fixes. This concludes more than one
year of efforts to bring a new and improved Apache Camel. Many
thanks to everybody in the community who contributed to this release.
Please find the staging repo here:
https://repository.apache.org/content/groups/staging/org/apache/camel/
The tarballs are here
https://repository.apache.org/content/groups/staging/org/apache/camel/apache-camel/2.0.0/
Please vote to approve this release binary
[ ] +1 Release the binary as Apache Camel 2.0-M3
[ ] -1 Veto the release (provide specific comments)
Vote is open for 72 hours.
The Camel Riders
