[ 
https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54000#action_54000
 ] 

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

Xueqiang,

Just took a look at your latest patch; liking the create route feature! Not 
sure about the view all routes though... looks bit messy IMHO and I doubt folks 
would always want to view their routes as only Groovy... maybe disable that 
screen for now? I also had a few test failures after applying the patch

{code}
Failed tests: 
  testTracePerRotueManual(org.apache.camel.web.groovy.TracingDSLTest)
  testInterceptFromUriRegex(org.apache.camel.web.groovy.InterceptFromDSLTest)
  
testInterceptFromUriSimpleLog(org.apache.camel.web.groovy.InterceptFromDSLTest)
  testInterceptFromUriWildcard(org.apache.camel.web.groovy.InterceptFromDSLTest)

Tests run: 162, Failures: 4, Errors: 0, Skipped: 14
{code}

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, 
> camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, 
> camel-20090817.patch, camel-20090818.patch, camel-20090821.patch, 
> camel-2009082101.patch, camel-web-20090629.patch, camel-web-20090703.patch, 
> camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, 
> camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch, 
> camel-web-20090902.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to