On Mon, Dec 28, 2009 at 10:14 AM, Willem Jiang <willem.ji...@gmail.com> wrote: > Hi Claus, > > If we don't make Spring 3.0 to be default for Camel 2.2, we will face a > problem that camel-spring-javaconfig can be built by default, as I already > upgraded the camel-spring-javaconfig to use Spring 3.0.0. > > If we are OK for leave the camel-spring-javaconfig along, I'd like to switch > the camel trunk to use Spring 2.5.6 by default. >
Why is it not possible to only let camel-spring-javaconfig use Spring 3.0.0 and all the others 2.5.6 ? > Willem > > Claus Ibsen wrote: >> >> Hi >> >> I dont think Spring 3.0 should be the default in Camel 2.2. >> >> There are still to many other frameworks that are dependent on 2.5. It >> just makes to much trouble for end users if they have to mess with >> maven files to downgrade to Spring 2.5. Without noticing this you end >> up with both 2.5 and 3.0 on the classpath. >> >> Its however still good that Camel works with both 2.5 and 3.0. Then >> later when 3.0 is more mainstream we can switch and make it default. >> >> I am -1 on making Spring 3.0 default in Camel 2.2 >> >> >> >> >> On Thu, Dec 24, 2009 at 9:34 AM, Claus Ibsen <claus.ib...@gmail.com> >> wrote: >>> >>> On Wed, Dec 23, 2009 at 10:58 AM, Gert Vanthienen >>> <gert.vanthie...@gmail.com> wrote: >>>> >>>> L.S., >>>> >>>> Do we need to maintain support for spring 2.5 java config in Camel >>>> trunk? Wouldn't it make more sense to migrate trunk to Spring 3.0 >>>> entirely and stick to 2.5 for one or more branches? I agree we should >>>> try to make sure that Camel trunk works with 2.5 as much as possible, >>>> but I don't think there would be a real issue in telling the >>>> camel-spring-javaconfig users that this requires Spring 3 (for Camel >>>> 2.2 and above). >>>> >>> +1 >>> >>> Spring Java Config is kinda @deprecated. Its now standard in spring 3.0. >>> So I see no harm letting camel-spring-javaconfig be Spring 3.0 only. >>> >>> And its only a few few users who use it anyway. Its not a central and >>> key component anyway. >>> >>> >>>> Regards, >>>> >>>> Gert Vanthienen >>>> ------------------------ >>>> Open Source SOA: http://fusesource.com >>>> Blog: http://gertvanthienen.blogspot.com/ >>>> >>>> >>>> >>>> 2009/12/23 Willem Jiang <willem.ji...@gmail.com>: >>>>> >>>>> Just a quick updated, I managed to get ride of most failed tests in >>>>> camel-spring and camel-jms by some simple fix. >>>>> >>>>> The issue for camel-spring is caused by CamelEndpointFactory, and the >>>>> issue >>>>> of camel-jms is the default JMS listenContainer doesn't seem to >>>>> autostart by >>>>> default anymore. >>>>> >>>>> Now there is the camel-spring-configure issue, I will create a JIRA for >>>>> it. >>>>> >>>>> Willem >>>>> >>>>> Claus Ibsen wrote: >>>>>> >>>>>> Good start. >>>>>> >>>>>> Dejan created a ticket in AMQ to get it working with Spring 3.0. >>>>>> >>>>>> And I think camel-jms depends on some API in 2.5 that was @deprecated. >>>>>> So we should take a 2nd look and mark it public as @deprecated as well >>>>>> in Camel 2.2. >>>>>> >>>>>> >>>>>> On Tue, Dec 22, 2009 at 3:36 PM, Willem Jiang <willem.ji...@gmail.com> >>>>>> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I just committed a spring-3.0 profile in trunk/parent/pom.xml. >>>>>>> You can build the camel with spring 3.0.0 by using -Pspring-3.0 >>>>>>> I just run some test in camel-core , camel-spring and camel-jms. >>>>>>> There about 4~5 tests are failed in camel-spring, and lots of tests >>>>>>> failed >>>>>>> in camel-jms. >>>>>>> >>>>>>> For the camel-spring-configure, as the spring java configure is a >>>>>>> part of >>>>>>> spring framework, lots changes there, we need to do change the >>>>>>> camel-spring-configure code. >>>>>>> So we can't support spring 3.0 and spring 2.x at the same time in >>>>>>> camel-spring-configure. >>>>>>> >>>>>> Yeah but Spring 3.0 have java config build in, so I think we may need >>>>>> a new component to support spring 3.0 and keep the one for 2.5. >>>>>> >>>>>>> For camel-spring-integration, it can run with spring 3.0 and spring >>>>>>> 2.x >>>>>>> and >>>>>>> the same time. >>>>>>> >>>>>>> Any thought? >>>>>> >>>>>>> Willem >>>>>>> >>>>>> >>>>>> >>>>> >>> >>> >>> -- >>> Claus Ibsen >>> Apache Camel Committer >>> >>> Author of Camel in Action: http://www.manning.com/ibsen/ >>> Open Source Integration: http://fusesource.com >>> Blog: http://davsclaus.blogspot.com/ >>> Twitter: http://twitter.com/davsclaus >>> >> >> >> > > -- Claus Ibsen Apache Camel Committer Author of Camel in Action: http://www.manning.com/ibsen/ Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus
