[ 
https://issues.apache.org/activemq/browse/CAMEL-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56882#action_56882
 ] 

Willem Jiang commented on CAMEL-2345:
-------------------------------------

Hi Hadrain,

Yes, CXF client and server side share the same code 
(ReflectionServiceFactoryBean) to create the ServiceModel.

If we don't specify the server name and port name, CXF will try to find a one 
for using, but if there are more than one service or one port, it will make us 
get into trouble of connecting a wrong endpoint. I think that is why William 
Tam added these checking.

How about we warning the user that don't set the service or the port name 
instead of using a NP checker?

Willem

> One should not have to explicitly provide the service/port for cxf is there's 
> only one
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2345
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2345
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-cxf
>    Affects Versions: 2.1.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>
> This is due to the following code in {{Client createClient()}} in 
> {{CxfEnpoint}}
> {code}
>         } else {
>             ObjectHelper.notNull(portName, "Please provide endpoint/port 
> name");
>             ObjectHelper.notNull(serviceName, "Please provide service name");
>             ClientFactoryBean factoryBean = createClientFactoryBean();
> {code}
> When there's only one service/port, we should just use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to