[
https://issues.apache.org/activemq/browse/CAMEL-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Mueller updated CAMEL-1530:
-------------------------------------
Attachment: client.jks
server.jks
camel-http-new-tests.patch
Hey Claus,
I finished my work on the unit tests (see attachment). I increased the number
of tests from 40 to 68. Now,
- all of the camel-http tests run without an internet connection
- we have a test for compression
- we have tests for authentication
- we have tests for working with proxies
- we have tests for http over ssl
- we have tests for all http methods
- we have tests for the 'charset' exchange property
- we have tests for the socket timeout
- we have tests for the 'throwExceptionOnFailure' option
I don't know, if you want to apply the tests by now for the 2.2 release or not
before 2.3. I added the dependencies to http client 4.0.1 temporarily in the
camel-http pom.xml, so we could have dependencies to both versions (3.1 for the
component and 4.0.1 for the tests).
During writing the tests, I thought about the following thinks. What do you
think?
- Because camel-http should not used as a consumer, should we remove the
HttpConsumer and the HttpPollingConsumer in 2.3 and throw an exception, if
somebody uses camel-http in a from route?
- Because httpClient changed the keys of the http params, we also changes the
documentation for camel-http httpClient params and our users has to change
there applications. We do not map the old names to the new ones.
- I think the documentation for configuring the charset is wrong. Setting the
charset with the following url 'httpClient.contentCharset=ISO-8859-1' has no
impact (please have a look on HttpCharsetTest.sendCharsetInQuery).
EntityEnclosingMethod (line 499) writes the content of the StringRequestEntity,
which is a byte array generated with the os default charset, and not with the
charset we have configured in the http client.
@Oleg: Which impact has the property 'contentCharset' in HttpClientParams on
the client site (version 3.1)? StringRequestEntity don't use this parameter to
generate the byte array...
Regards,
Christian
> Upgrade camel-http to use httpclient 4.0
> ----------------------------------------
>
> Key: CAMEL-1530
> URL: https://issues.apache.org/activemq/browse/CAMEL-1530
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Claus Ibsen
> Assignee: Christian Mueller
> Fix For: 2.3.0
>
> Attachments: camel-http-new-tests.patch, camel-http-test.patch,
> camel-http.patch, client.jks, server.jks
>
>
> Upgrading httpclient from 3.1 to 4.0 requires changes in the camel-http code
> as the API has change quite a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
