Hi I do NOT think we should enlist temporary JMS queues in JMX management, the overhead is way to high for that. Since those queues are temporary they live for a short time and management is more about long lived resources to manage.
Can we do a -1 on this and implement logic to skip trying to register those kind of endpoints for management. On Wed, Feb 10, 2010 at 3:39 AM, <ningji...@apache.org> wrote: > Author: ningjiang > Date: Wed Feb 10 02:39:35 2010 > New Revision: 908326 > > URL: http://svn.apache.org/viewvc?rev=908326&view=rev > Log: > CAMEL-2456 added ManagedResource annotation on JmsTemporaryQueueEndpoint and > JmsTemporaryTopicEndpoint > > Modified: > > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryQueueEndpoint.java > > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryTopicEndpoint.java > > Modified: > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryQueueEndpoint.java > URL: > http://svn.apache.org/viewvc/camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryQueueEndpoint.java?rev=908326&r1=908325&r2=908326&view=diff > ============================================================================== > --- > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryQueueEndpoint.java > (original) > +++ > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryQueueEndpoint.java > Wed Feb 10 02:39:35 2010 > @@ -21,6 +21,8 @@ > import javax.jms.Session; > import javax.jms.TemporaryQueue; > > +import org.springframework.jmx.export.annotation.ManagedResource; > + > /** > * A <a href="http://activemq.apache.org/jms.html";>JMS Endpoint</a> > * for working with a {...@link TemporaryQueue} > @@ -28,6 +30,7 @@ > * @version $Revision$ > */ > // TODO need to be really careful to always use the same Connection > otherwise the destination goes stale > +...@managedresource(description = "Managed JMS Temporary Queue Endpoint") > public class JmsTemporaryQueueEndpoint extends JmsQueueEndpoint implements > DestinationEndpoint { > private Destination jmsDestination; > > > Modified: > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryTopicEndpoint.java > URL: > http://svn.apache.org/viewvc/camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryTopicEndpoint.java?rev=908326&r1=908325&r2=908326&view=diff > ============================================================================== > --- > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryTopicEndpoint.java > (original) > +++ > camel/trunk/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsTemporaryTopicEndpoint.java > Wed Feb 10 02:39:35 2010 > @@ -21,6 +21,8 @@ > import javax.jms.Session; > import javax.jms.TemporaryTopic; > > +import org.springframework.jmx.export.annotation.ManagedResource; > + > /** > * A <a href="http://activemq.apache.org/jms.html";>JMS Endpoint</a> > * for working with a {...@link TemporaryTopic} > @@ -28,6 +30,7 @@ > * @version $Revision$ > */ > // TODO need to be really careful to always use the same Connection > otherwise the destination goes stale > +...@managedresource(description = "Managed JMS Temporay Topic Endpoint") > public class JmsTemporaryTopicEndpoint extends JmsEndpoint implements > DestinationEndpoint { > private Destination jmsDestination; > > > > -- Claus Ibsen Apache Camel Committer Author of Camel in Action: http://www.manning.com/ibsen/ Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus
