[ 
https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58048#action_58048
 ] 

Ashwin Karpe commented on CAMEL-2371:
-------------------------------------

Hi Claus,

Thanks for the feedback. I will work on the changes you suggested and submit 
the next iteration for your review and comment.

I will try to get it done by this weekend. I am on a customer gig all day 
tomorrow and proceed on vacation all of next week and may not be able to get a 
chance to work on it. In the event I cannot get it done this weekend, please 
bear with me. I will try and submit it early the week following.

As for the annotation *...@channelpipelinecoverage("all")*** it simply means 
that the same handler may be applied against multiple channel pipeline 
instances. The only options available are "one" and "all". The choice of "one" 
will force creation of individual handler instances per pipeline. 

The exceptionCaught()  debug statement stating that the channel is closed but 
the fact that it is not is a glitch. I need to rework the debug statement 
(possibly even remove the method and fall back on default handling). Channel 
closure is not essential since there are some cases where exceptions caught are 
not fatal in nature. 
 
I will make the countdownLatch local and check out ServicePoolAware. That is a 
good catch. I did not pick up on this implication during development. Thanks.

Cheers,

Ashwin...

> Netty component
> ---------------
>
>                 Key: CAMEL-2371
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2371
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: Future
>
>         Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component 
> as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ 
> years and still not released. 
> And one of the primary drivers behind MINA joined JBoss and created Netty 
> instead. It appears as a good alternative.
> Netty is also Apache licensed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to