[ 
https://issues.apache.org/activemq/browse/CAMEL-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashwin Karpe updated CAMEL-2631:
--------------------------------

    Attachment: time-pattern-converter-patch3.diff

Hi Claus,

I have made the changes you suggested (TraceEnabled() etc) . I found out that I 
cannot apply the [h|H|hour|Hour|hours|hours] rule since Regex pattern matches 
are of the eager variety and cause side-effects (each character to be 
independently evaluated like 'h''o''u''r''s').

In any case all of the patterns you need supported work with the pattern set I 
have created. I have also added a Timer based test as you recommended with a 
timer period set to 5s. This can be anything in the supported 
TimerPatternConverter.

Please let me know whether there is anything else you need before I commit the 
feature.  

Cheers,

Ashwin...

> Add time millis converter which can convert from String to long
> ---------------------------------------------------------------
>
>                 Key: CAMEL-2631
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2631
>             Project: Apache Camel
>          Issue Type: New Feature
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>         Attachments: time-pattern-converter-patch3.diff
>
>
> Its currently a bit annoying to set a delay by millis and if you need, like 1 
> hour 30 min period. What is this in millis?
> We should add a TypeConverter for that which has a String notation such as:
> {code}
> 1h30m
> 3h45m25s
> 10m
> 15m20s
> 30s
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to