[
https://issues.apache.org/activemq/browse/CAMEL-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59105#action_59105
]
Claus Ibsen commented on CAMEL-2631:
------------------------------------
Still some comments
1)
Do not use new String, this is not best practice
2)
In this test TimePatternTypeConversionTest do not create the CamelContext
yourself as you extend ContextTestSupport which creates the context for you
3)
You should add tests which test with JUST numbers, eg "444" to see that your
get a long 444 value.
And double check that type converting a JUST number works out of the box. So
there are no unforeseen side side effects.
4)
And remove code which should be removed (eg code which you have added // )
> Add time millis converter which can convert from String to long
> ---------------------------------------------------------------
>
> Key: CAMEL-2631
> URL: https://issues.apache.org/activemq/browse/CAMEL-2631
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Priority: Minor
> Attachments: time-pattern-converter-patch5.diff
>
>
> Its currently a bit annoying to set a delay by millis and if you need, like 1
> hour 30 min period. What is this in millis?
> We should add a TypeConverter for that which has a String notation such as:
> {code}
> 1h30m
> 3h45m25s
> 10m
> 15m20s
> 30s
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
