On Tue, Jun 1, 2010 at 9:44 AM, Guillaume Nodet <gno...@gmail.com> wrote: > Yeah, i'm on it. Committing in a minute. >
Thanks it works better now in the osgi tests. However now they fail for other kind of reasons. Just would be nice that we get those unit tests up and running so we can use them when we "touch" any OSGi related to help ensure we do not break stuff. ------------------------------------------------------------------------------- Test set: org.apache.camel.itest.karaf.CamelBindyTest ------------------------------------------------------------------------------- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.205 sec <<< FAILURE! test [felix](org.apache.camel.itest.karaf.CamelBindyTest) Time elapsed: 3.102 sec <<< ERROR! java.lang.NoClassDefFoundError: org/apache/camel/osgi/CamelContextFactory at org.apache.camel.itest.karaf.AbstractFeatureTest.createCamelContext(AbstractFeatureTest.java:133) at org.apache.camel.itest.karaf.AbstractFeatureTest.testDataFormat(AbstractFeatureTest.java:80) at org.apache.camel.itest.karaf.CamelBindyTest.test(CamelBindyTest.java:39) > On Tue, Jun 1, 2010 at 09:37, Willem Jiang <willem.ji...@gmail.com> wrote: >> Hi Guillaume, >> >> I just checked the camel-blueprint which use bnd to create the bundle, it's >> includes the camel-core-xml and camel-core-osgi classes, >> But for the camel-osgi it's not a osgi bundle anymore, and camel-sprint >> doesn't includes the camel-core-xml's class, I think we need to update the >> pom.xml files for it. >> >> Willem >> >> Guillaume Nodet wrote: >>> >>> Those are not needed afaik. Those two jars are actually not bundles >>> and they are both included in camel-osgi / camel-spring and >>> camel-blueprint, so I don't really think it's needed at all. At >>> least that was my goal. I've just restarted doing some more testing >>> in this area. >>> >>> On Tue, Jun 1, 2010 at 08:52, <davscl...@apache.org> wrote: >>>> >>>> Author: davsclaus >>>> Date: Tue Jun 1 06:52:53 2010 >>>> New Revision: 949939 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=949939&view=rev >>>> Log: >>>> CAMEL-2702: Fixing features to include the new required components. >>>> >>>> Modified: >>>> >>>> camel/trunk/platforms/karaf/features/src/main/resources/features-spring3.xml >>>> camel/trunk/platforms/karaf/features/src/main/resources/features.xml >>>> >>>> Modified: >>>> camel/trunk/platforms/karaf/features/src/main/resources/features-spring3.xml >>>> URL: >>>> http://svn.apache.org/viewvc/camel/trunk/platforms/karaf/features/src/main/resources/features-spring3.xml?rev=949939&r1=949938&r2=949939&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> camel/trunk/platforms/karaf/features/src/main/resources/features-spring3.xml >>>> (original) >>>> +++ >>>> camel/trunk/platforms/karaf/features/src/main/resources/features-spring3.xml >>>> Tue Jun 1 06:52:53 2010 >>>> @@ -47,6 +47,8 @@ >>>> <feature version='${spring-osgi-version}'>spring-dm</feature> >>>> <bundle>mvn:org.springframework/spring-tx/${spring3-version}</bundle> >>>> <feature version='${pom.version}'>camel-core</feature> >>>> + <bundle>mvn:org.apache.camel/camel-core-xml/${pom.version}</bundle> >>>> + <bundle>mvn:org.apache.camel/camel-core-osgi/${pom.version}</bundle> >>>> <bundle>mvn:org.apache.camel/camel-spring-osgi/${pom.version}</bundle> >>>> </feature> >>>> <feature name='camel-test' version='${pom.version}'> >>>> >>>> Modified: >>>> camel/trunk/platforms/karaf/features/src/main/resources/features.xml >>>> URL: >>>> http://svn.apache.org/viewvc/camel/trunk/platforms/karaf/features/src/main/resources/features.xml?rev=949939&r1=949938&r2=949939&view=diff >>>> >>>> ============================================================================== >>>> --- camel/trunk/platforms/karaf/features/src/main/resources/features.xml >>>> (original) >>>> +++ camel/trunk/platforms/karaf/features/src/main/resources/features.xml >>>> Tue Jun 1 06:52:53 2010 >>>> @@ -47,6 +47,8 @@ >>>> <feature version='${spring-osgi-version}'>spring-dm</feature> >>>> <bundle>mvn:org.springframework/spring-tx/${spring-version}</bundle> >>>> <feature version='${pom.version}'>camel-core</feature> >>>> + <bundle>mvn:org.apache.camel/camel-core-xml/${pom.version}</bundle> >>>> + <bundle>mvn:org.apache.camel/camel-core-osgi/${pom.version}</bundle> >>>> <bundle>mvn:org.apache.camel/camel-spring-osgi/${pom.version}</bundle> >>>> </feature> >>>> <feature name='camel-test' version='${pom.version}'> >>>> >>>> >>>> >>> >>> >>> >> >> > > > > -- > Cheers, > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > Open Source SOA > http://fusesource.com > -- Claus Ibsen Apache Camel Committer Author of Camel in Action: http://www.manning.com/ibsen/ Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus