Yeah, that would make sense. In that case, maybe a very short comment would be welcomed to indicate that this is indeed required !
On Thu, Jun 3, 2010 at 21:15, Jon Anstey <[email protected]> wrote: > I think this gross bit of code > > ProcessorDefinition defn = (ProcessorDefinition) this; > if (defn instanceof TryDefinition) { > > was needed to compile on AIX. I can't recall why this was needed so it may > not be an issue anymore but I guess you'll see in the next AIX build :) > > On Thu, Jun 3, 2010 at 4:38 PM, <[email protected]> wrote: > >> Author: gnodet >> Date: Thu Jun 3 19:08:36 2010 >> New Revision: 951115 >> >> URL: http://svn.apache.org/viewvc?rev=951115&view=rev >> Log: >> Remove a few ide warnings >> >> Modified: >> >> camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java >> >> Modified: >> camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java >> URL: >> http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java?rev=951115&r1=951114&r2=951115&view=diff >> >> ============================================================================== >> --- >> camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java >> (original) >> +++ >> camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java >> Thu Jun 3 19:08:36 2010 >> @@ -997,8 +997,7 @@ public abstract class ProcessorDefinitio >> // when using doTry .. doCatch .. doFinally we should always >> // end the try definition to avoid having to use 2 x end() in the >> route >> // this is counter intuitive for end users >> - ProcessorDefinition defn = (ProcessorDefinition) this; >> - if (defn instanceof TryDefinition) { >> + if (this instanceof TryDefinition) { >> popBlock(); >> } >> >> @@ -1370,7 +1369,7 @@ public abstract class ProcessorDefinitio >> * Creates a routing slip allowing you to route a message consecutively >> through a series of processing >> * steps where the sequence of steps is not known at design time and >> can vary for each message. >> * >> - * @param expresion to decide the destinations >> + * @param expression to decide the destinations >> * @param uriDelimiter is the delimiter that will be used to split up >> * the list of URIs in the routing slip. >> * >> @@ -1389,7 +1388,7 @@ public abstract class ProcessorDefinitio >> * <p> >> * The list of URIs will be split based on the default delimiter >> {...@link >> RoutingSlipDefinition#DEFAULT_DELIMITER} >> * >> - * @param expresion to decide the destinations >> + * @param expression to decide the destinations >> * >> * @return the builder >> */ >> @@ -2186,7 +2185,7 @@ public abstract class ProcessorDefinitio >> */ >> public ExpressionClause<ProcessorDefinition<Type>> transform() { >> ExpressionClause<ProcessorDefinition<Type>> clause = >> - new >> ExpressionClause<ProcessorDefinition<Type>>((ProcessorDefinition<Type>) >> this); >> + new ExpressionClause<ProcessorDefinition<Type>>(this); >> TransformDefinition answer = new TransformDefinition(clause); >> addOutput(answer); >> return clause; >> >> >> > > > -- > Cheers, > Jon > > Camel in Action: http://manning.com/ibsen > Blog: http://janstey.blogspot.com > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
